Patchwork D1046: tweakdefaults: enable rebase

login
register
mail settings
Submitter phabricator
Date Oct. 13, 2017, 6:02 a.m.
Message ID <differential-rev-PHID-DREV-7ufki6uhayqtfyqxmwmw-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/24810/
State Superseded
Headers show

Comments

phabricator - Oct. 13, 2017, 6:02 a.m.
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Rebase could be a frequently used command and concept. Therefore enabled.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1046

AFFECTED FILES
  mercurial/ui.py

CHANGE DETAILS




To: quark, #hg-reviewers
Cc: mercurial-devel
phabricator - Oct. 13, 2017, 5:41 p.m.
ryanmce accepted this revision as: ryanmce.
ryanmce added a comment.


  Accepting as myself (not as a reviewer though, since we're both FB). I'm a big +1 on this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1046

To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
phabricator - Oct. 13, 2017, 7:36 p.m.
durin42 added a comment.


  Until we've got a plan for obsolete markers on by default (even if without marker exchange), I think I'd rather hold off on this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1046

To: quark, #hg-reviewers, ryanmce
Cc: durin42, ryanmce, mercurial-devel
phabricator - Oct. 13, 2017, 7:42 p.m.
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.


  Actually, beyond that: if something is safe enough to be in tweakdefaults and it's not a BC change, it should *be on by default*. As such, turning on a command like rebase is IMO out of scope for tweakdefaults, and you should instead be having the discussion about what it takes to make rebase (and histedit) on by default.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1046

To: quark, #hg-reviewers, ryanmce, durin42
Cc: durin42, ryanmce, mercurial-devel

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -54,6 +54,10 @@ 
 # Make `hg status` emit cwd-relative paths by default.
 status.relative = yes
 
+[extensions]
+# Make `rebase` available.
+rebase =
+
 [diff]
 git = 1
 """