From patchwork Thu Oct 12 16:37:29 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D1021: check-code: forbid platform.system()
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 24793
Message-Id: <6bd0579b801ec56409a7c4313ce506a5@localhost.localdomain>
To: mercurial-devel@mercurial-scm.org
Date: Thu, 12 Oct 2017 16:37:29 +0000

quark updated this revision to Diff 2634.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1021?vs=2608&id=2634

REVISION DETAIL
  https://phab.mercurial-scm.org/D1021

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: quark, #hg-reviewers, lothiraldan
Cc: ryanmce, lothiraldan, mercurial-devel

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -362,6 +362,7 @@
     (r'\.next\(\)', "don't use .next(), use next(...)"),
     (r'([a-z]*).revision\(\1\.node\(',
      "don't convert rev to node before passing to revision(nodeorrev)"),
+    (r'platform\.system\(\)', "don't use platform.system(), use pycompat"),
 
     # rules depending on implementation of repquote()
     (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',