Patchwork D1021: check-code: forbid platform.system()

login
register
mail settings
Submitter phabricator
Date Oct. 12, 2017, 4:37 p.m.
Message ID <6bd0579b801ec56409a7c4313ce506a5@localhost.localdomain>
Download mbox | patch
Permalink /patch/24793/
State Not Applicable
Headers show

Comments

phabricator - Oct. 12, 2017, 4:37 p.m.
quark updated this revision to Diff 2634.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1021?vs=2608&id=2634

REVISION DETAIL
  https://phab.mercurial-scm.org/D1021

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: quark, #hg-reviewers, lothiraldan
Cc: ryanmce, lothiraldan, mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -362,6 +362,7 @@ 
     (r'\.next\(\)', "don't use .next(), use next(...)"),
     (r'([a-z]*).revision\(\1\.node\(',
      "don't convert rev to node before passing to revision(nodeorrev)"),
+    (r'platform\.system\(\)', "don't use platform.system(), use pycompat"),
 
     # rules depending on implementation of repquote()
     (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',