Patchwork D1030: mpatch: switch alignment of wrapped line from tab to spaces with clang-format

login
register
mail settings
Submitter phabricator
Date Oct. 12, 2017, 3:10 p.m.
Message ID <differential-rev-PHID-DREV-e4h6overltpk26dyaojz-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/24786/
State Superseded
Headers show

Comments

phabricator - Oct. 12, 2017, 3:10 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I may be a weird person for liking this style, but our C style is
  historically nominally the Linux Kernel style, and when you configure
  clang-format to be kernel-ish, this is what you get. If we want to
  change it, we can do so by tweaking the formatter rules in the future.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1030

AFFECTED FILES
  mercurial/mpatch.c

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Oct. 12, 2017, 6:46 p.m.
pulkit accepted this revision.
pulkit added a comment.


  Those who are struggling seeing the diff here or in similar cases, click on History tab which is next to File one, just under the Revision content on this page and you will "Whitespace change" thing in the right and change it to show all. :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1030

To: durin42, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel
phabricator - Oct. 13, 2017, 5:42 p.m.
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.


  Seems like we should figure out the spacing stuff on https://phab.mercurial-scm.org/D1028 before moving forward here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1030

To: durin42, #hg-reviewers, pulkit, ryanmce
Cc: ryanmce, pulkit, mercurial-devel

Patch

diff --git a/mercurial/mpatch.c b/mercurial/mpatch.c
--- a/mercurial/mpatch.c
+++ b/mercurial/mpatch.c
@@ -275,5 +275,5 @@ 
 	/* divide and conquer, memory management is elsewhere */
 	len = (end - start) / 2;
 	return combine(mpatch_fold(bins, get_next_item, start, start + len),
-		       mpatch_fold(bins, get_next_item, start + len, end));
+	               mpatch_fold(bins, get_next_item, start + len, end));
 }