Patchwork chg: remove outdated rule to start test server

login
register
mail settings
Submitter Yuya Nishihara
Date Oct. 12, 2017, 1:56 p.m.
Message ID <9b41113b9c4397dec6bb.1507816595@mimosa>
Download mbox | patch
Permalink /patch/24782/
State Accepted
Headers show

Comments

Yuya Nishihara - Oct. 12, 2017, 1:56 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1507814474 -32400
#      Thu Oct 12 22:21:14 2017 +0900
# Node ID 9b41113b9c4397dec6bb198973a8231533f56bce
# Parent  26273fe219811ac0e87f030a2d9c8ed50f4f4768
chg: remove outdated rule to start test server

This rule is no longer useful because chg daemon may be killed and respawned
per config/environment hash. We can't reliably run a daemon in foreground.
Augie Fackler - Oct. 13, 2017, 4:24 p.m.
On Thu, Oct 12, 2017 at 10:56:35PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1507814474 -32400
> #      Thu Oct 12 22:21:14 2017 +0900
> # Node ID 9b41113b9c4397dec6bb198973a8231533f56bce
> # Parent  26273fe219811ac0e87f030a2d9c8ed50f4f4768
> chg: remove outdated rule to start test server

queued, thanks

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -181,7 +181,6 @@  osx:
 	make -C contrib/chg \
 	  HGPATH=/usr/local/bin/hg \
 	  PYTHON=/usr/bin/python2.7 \
-	  HG=/usr/local/bin/hg \
 	  HGEXTDIR=/Library/Python/2.7/site-packages/hgext \
 	  DESTDIR=../../build/mercurial \
 	  PREFIX=/usr/local \
diff --git a/contrib/chg/Makefile b/contrib/chg/Makefile
--- a/contrib/chg/Makefile
+++ b/contrib/chg/Makefile
@@ -1,5 +1,3 @@ 
-HG = $(CURDIR)/../../hg
-
 TARGET = chg
 SRCS = chg.c hgclient.c procutil.c util.c
 OBJS = $(SRCS:.c=.o)
@@ -15,9 +13,6 @@  DESTDIR =
 PREFIX = /usr/local
 MANDIR = $(PREFIX)/share/man/man1
 
-CHGSOCKDIR = /tmp/chg$(shell id -u)
-CHGSOCKNAME = $(CHGSOCKDIR)/server
-
 .PHONY: all
 all: $(TARGET)
 
@@ -36,13 +31,6 @@  install: $(TARGET)
 	install -d "$(DESTDIR)$(MANDIR)"
 	install -m 644 chg.1 "$(DESTDIR)$(MANDIR)"
 
-.PHONY: serve
-serve:
-	[ -d "$(CHGSOCKDIR)" ] || ( umask 077; mkdir "$(CHGSOCKDIR)" )
-	"$(HG)" serve --cwd / --cmdserver chgunix \
-		--address $(CHGSOCKNAME) \
-		--config cmdserver.log=/dev/stderr
-
 .PHONY: clean
 clean:
 	$(RM) $(OBJS)