Patchwork D1000: contrib: add check-code rule banning use of readlink

login
register
mail settings
Submitter phabricator
Date Oct. 11, 2017, 9 a.m.
Message ID <97821918d6222fd5041c0f9619080eee@localhost.localdomain>
Download mbox | patch
Permalink /patch/24716/
State Not Applicable
Headers show

Comments

phabricator - Oct. 11, 2017, 9 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGac80a8d105ec: contrib: add check-code rule banning use of readlink (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1000?vs=2566&id=2578

REVISION DETAIL
  https://phab.mercurial-scm.org/D1000

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers, quark, ryanmce
Cc: ryanmce, quark, mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -203,6 +203,7 @@ 
      'use test -f to test for file existence'),
     (r'^  diff -[^ -]*p',
      "don't use (external) diff with -p for portability"),
+    (r' readlink ', 'use readlink.py instead of readlink'),
     (r'^  [-+][-+][-+] .* [-+]0000 \(glob\)',
      "glob timezone field in diff output for portability"),
     (r'^  @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',