Patchwork [1,of,5] configitems: register the 'phases.new-commit' config

login
register
mail settings
Submitter Boris Feld
Date Oct. 4, 2017, 2:33 p.m.
Message ID <1b1349c23e37cfc6e82e.1507127620@FB>
Download mbox | patch
Permalink /patch/24484/
State Accepted
Headers show

Comments

Boris Feld - Oct. 4, 2017, 2:33 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1498787028 -7200
#      Fri Jun 30 03:43:48 2017 +0200
# Node ID 1b1349c23e37cfc6e82ea05ad4bbf8fbcfc9aa09
# Parent  2fd06499dc8e6a5a784b1334b925c289d7b54e4e
# EXP-Topic config.register.core
configitems: register the 'phases.new-commit' config
Yuya Nishihara - Oct. 5, 2017, 1:16 p.m.
On Wed, 04 Oct 2017 16:33:40 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1498787028 -7200
> #      Fri Jun 30 03:43:48 2017 +0200
> # Node ID 1b1349c23e37cfc6e82ea05ad4bbf8fbcfc9aa09
> # Parent  2fd06499dc8e6a5a784b1334b925c289d7b54e4e
> # EXP-Topic config.register.core
> configitems: register the 'phases.new-commit' config

Queued, thanks.

> diff -r 2fd06499dc8e -r 1b1349c23e37 mercurial/configitems.py
> --- a/mercurial/configitems.py	Thu Aug 24 18:40:30 2017 +0200
> +++ b/mercurial/configitems.py	Fri Jun 30 03:43:48 2017 +0200
> @@ -317,6 +317,9 @@
>  coreconfigitem('phases', 'checksubrepos',
>      default='follow',
>  )
> +coreconfigitem('phases', 'new-commit',
> +    default=dynamicdefault,
> +)

Nit: the default is 'draft'. Is there any problem?

Patch

diff -r 2fd06499dc8e -r 1b1349c23e37 mercurial/configitems.py
--- a/mercurial/configitems.py	Thu Aug 24 18:40:30 2017 +0200
+++ b/mercurial/configitems.py	Fri Jun 30 03:43:48 2017 +0200
@@ -317,6 +317,9 @@ 
 coreconfigitem('phases', 'checksubrepos',
     default='follow',
 )
+coreconfigitem('phases', 'new-commit',
+    default=dynamicdefault,
+)
 coreconfigitem('phases', 'publish',
     default=True,
 )