Patchwork D911: test-pager: make it compatible with chg

login
register
mail settings
Submitter phabricator
Date Oct. 4, 2017, 1:16 p.m.
Message ID <657c0203e3684547c485df216486d3b5@localhost.localdomain>
Download mbox | patch
Permalink /patch/24458/
State Not Applicable
Headers show

Comments

phabricator - Oct. 4, 2017, 1:16 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG73d8a5283f87: test-pager: make it compatible with chg (authored by quark, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D911?vs=2366&id=2397

REVISION DETAIL
  https://phab.mercurial-scm.org/D911

AFFECTED FILES
  tests/test-pager.t

CHANGE DETAILS




To: quark, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -195,6 +195,7 @@ 
   paged! 'summary:     modify a 8\n'
   paged! '\n'
 
+#if no-chg
 An invalid pager command name is reported sensibly if we don't have to
 use shell=True in the subprocess call:
   $ hg log --limit 3 --config pager.pager=this-command-better-never-exist
@@ -215,6 +216,17 @@ 
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     modify a 8
   
+#else
+Currently, chg has its own runpager implementation, which does not show the
+"missing pager" message. The error message is globed out since the shell could
+print different message.
+  $ hg log --limit 3 --config pager.pager=this-command-better-never-exist
+  /bin/sh: this-command-better-never-exist: command not found (?)
+  * (glob) (?)
+  killed!
+  [255]
+
+#endif
 
 A complicated pager command gets worse behavior. Bonus points if you can
 improve this.