Patchwork [01,of,17] bugzilla: remove superfluous pass statements

login
register
mail settings
Submitter Augie Fackler
Date Sept. 30, 2017, 12:02 p.m.
Message ID <200bd11a6fbb0a6f6667.1506772927@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/24234/
State Accepted
Headers show

Comments

Augie Fackler - Sept. 30, 2017, 12:02 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1506700526 14400
#      Fri Sep 29 11:55:26 2017 -0400
# Node ID 200bd11a6fbb0a6f6667e65fd0af721e54e39d20
# Parent  ac0cd81e2f83cd6a2910c61afbb98a415832f8e7
bugzilla: remove superfluous pass statements
Gregory Szorc - Sept. 30, 2017, 3:06 p.m.
On Sat, Sep 30, 2017 at 1:02 PM, Augie Fackler <raf@durin42.com> wrote:

> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1506700526 14400
> #      Fri Sep 29 11:55:26 2017 -0400
> # Node ID 200bd11a6fbb0a6f6667e65fd0af721e54e39d20
> # Parent  ac0cd81e2f83cd6a2910c61afbb98a415832f8e7
> bugzilla: remove superfluous pass statements
>

Queued, thanks.


>
> diff --git a/hgext/bugzilla.py b/hgext/bugzilla.py
> --- a/hgext/bugzilla.py
> +++ b/hgext/bugzilla.py
> @@ -412,11 +412,9 @@ class bzaccess(object):
>
>      def filter_real_bug_ids(self, bugs):
>          '''remove bug IDs that do not exist in Bugzilla from bugs.'''
> -        pass
>
>      def filter_cset_known_bug_ids(self, node, bugs):
>          '''remove bug IDs where node occurs in comment text from bugs.'''
> -        pass
>
>      def updatebug(self, bugid, newstate, text, committer):
>          '''update the specified bug. Add comment text and set new states.
> @@ -424,7 +422,6 @@ class bzaccess(object):
>          If possible add the comment as being from the committer of
>          the changeset. Otherwise use the default Bugzilla user.
>          '''
> -        pass
>
>      def notify(self, bugs, committer):
>          '''Force sending of Bugzilla notification emails.
> @@ -432,7 +429,6 @@ class bzaccess(object):
>          Only required if the access method does not trigger notification
>          emails automatically.
>          '''
> -        pass
>
>  # Bugzilla via direct access to MySQL database.
>  class bzmysql(bzaccess):
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/hgext/bugzilla.py b/hgext/bugzilla.py
--- a/hgext/bugzilla.py
+++ b/hgext/bugzilla.py
@@ -412,11 +412,9 @@  class bzaccess(object):
 
     def filter_real_bug_ids(self, bugs):
         '''remove bug IDs that do not exist in Bugzilla from bugs.'''
-        pass
 
     def filter_cset_known_bug_ids(self, node, bugs):
         '''remove bug IDs where node occurs in comment text from bugs.'''
-        pass
 
     def updatebug(self, bugid, newstate, text, committer):
         '''update the specified bug. Add comment text and set new states.
@@ -424,7 +422,6 @@  class bzaccess(object):
         If possible add the comment as being from the committer of
         the changeset. Otherwise use the default Bugzilla user.
         '''
-        pass
 
     def notify(self, bugs, committer):
         '''Force sending of Bugzilla notification emails.
@@ -432,7 +429,6 @@  class bzaccess(object):
         Only required if the access method does not trigger notification
         emails automatically.
         '''
-        pass
 
 # Bugzilla via direct access to MySQL database.
 class bzmysql(bzaccess):