Patchwork [6,of,8,py3] drawdag: tagsmod.tag() takes a list of names, not a single name

login
register
mail settings
Submitter Augie Fackler
Date Sept. 15, 2017, 11:14 p.m.
Message ID <6780213e5a48edeef40d.1505517249@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/23926/
State Accepted
Headers show

Comments

Augie Fackler - Sept. 15, 2017, 11:14 p.m.
# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1503465841 14400
#      Wed Aug 23 01:24:01 2017 -0400
# Node ID 6780213e5a48edeef40d6fa24ef5cb939de8abdc
# Parent  370f8212917c1af7e6189d3f0a7ca59ec49d1a4a
drawdag: tagsmod.tag() takes a list of names, not a single name

We were getting lucky on Python 2 since we have only one-byte names,
but on Python 3 badness was happening.

Patch

diff --git a/tests/drawdag.py b/tests/drawdag.py
--- a/tests/drawdag.py
+++ b/tests/drawdag.py
@@ -346,7 +346,7 @@  def debugdrawdag(ui, repo, **opts):
         ctx = simplecommitctx(repo, name, pctxs, added)
         n = ctx.commit()
         committed[name] = n
-        tagsmod.tag(repo, name, n, message=None, user=None, date=None,
+        tagsmod.tag(repo, [name], n, message=None, user=None, date=None,
                     local=True)
 
     # handle special comments