Patchwork D651: blackbox: remove _bbvfs state

login
register
mail settings
Submitter phabricator
Date Sept. 12, 2017, 2:13 p.m.
Message ID <2efed85612b22e1fcac039de71eca2aa@localhost.localdomain>
Download mbox | patch
Permalink /patch/23813/
State Not Applicable
Headers show

Comments

phabricator - Sept. 12, 2017, 2:13 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG029b33adbd17: blackbox: remove _bbvfs state (authored by quark).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D651?vs=1654&id=1753

REVISION DETAIL
  https://phab.mercurial-scm.org/D651

AFFECTED FILES
  hgext/blackbox.py

CHANGE DETAILS




To: quark, #hg-reviewers, durham
Cc: mercurial-devel

Patch

diff --git a/hgext/blackbox.py b/hgext/blackbox.py
--- a/hgext/blackbox.py
+++ b/hgext/blackbox.py
@@ -82,19 +82,23 @@ 
             else:
                 self._bbinlog = False
                 self._bbrepo = getattr(src, '_bbrepo', None)
-                self._bbvfs = getattr(src, '_bbvfs', None)
 
         def _partialinit(self):
-            if util.safehasattr(self, '_bbvfs'):
+            if self._bbvfs:
                 return
             self._bbinlog = False
             self._bbrepo = None
-            self._bbvfs = None
 
         def copy(self):
             self._partialinit()
             return self.__class__(self)
 
+        @property
+        def _bbvfs(self):
+            repo = getattr(self, '_bbrepo', None)
+            if repo:
+                return repo.vfs
+
         @util.propertycache
         def track(self):
             return self.configlist('blackbox', 'track', ['*'])
@@ -194,7 +198,6 @@ 
         def setrepo(self, repo):
             self._bbinlog = False
             self._bbrepo = repo
-            self._bbvfs = repo.vfs
 
     ui.__class__ = blackboxui
     uimod.ui = blackboxui