Submitter | Jun Wu |
---|---|
Date | Sept. 3, 2017, 7:54 p.m. |
Message ID | <75cb2afd931082496524.1504468491@x1c> |
Download | mbox | patch |
Permalink | /patch/23650/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 09E3A2C1B8; Sun, 3 Sep 2017 15:55:40 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SMrkReArPczZ; Sun, 3 Sep 2017 15:55:39 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id 9492A2C1CA; Sun, 3 Sep 2017 15:55:39 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 2002A2C1CA for <mercurial-devel@mercurial-scm.org>; Sun, 3 Sep 2017 15:55:38 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JB8cLrt291wP for <mercurial-devel@mercurial-scm.org>; Sun, 3 Sep 2017 15:55:37 -0400 (EDT) Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by mercurial-scm.org (Postfix) with ESMTPS id 7BE212C1B8 for <mercurial-devel@mercurial-scm.org>; Sun, 3 Sep 2017 15:55:37 -0400 (EDT) Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v83Jssca029924 for <mercurial-devel@mercurial-scm.org>; Sun, 3 Sep 2017 12:55:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=content-type : mime-version : content-transfer-encoding : subject : message-id : date : from : to; s=facebook; bh=VVVc+5BGK1ozvxAwKEaReCajXWerACNzOrAPjtmkkyk=; b=TzF92cehYAbG+EGpWd4LBERmzb6S/uwanOkFYKKYVC0KYEFA2hxaKVByiu9oxC6LLXzi i4xMkTYyLn6yW7JtT5rBn4X/T7kmCGazbVvcbsJ+UzekdHeP/B+mVtccH0rUurWnC3Qa jHE5wJ8rSVo/JmKyTjrQJKjFH04BPEwhrgY= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2cr5wnspwh-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for <mercurial-devel@mercurial-scm.org>; Sun, 03 Sep 2017 12:55:37 -0700 Received: from PRN-CHUB02.TheFacebook.com (2620:10d:c081:35::11) by PRN-CHUB08.TheFacebook.com (2620:10d:c081:35::17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Sep 2017 12:55:36 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.12) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Sep 2017 12:55:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VVVc+5BGK1ozvxAwKEaReCajXWerACNzOrAPjtmkkyk=; b=Ex5PQBPX0a52kMh0pK/Yf3KVbunfAhmZB8nxi//0U2Vr8zFrzLJrQ3/rv6knh9Wdvp5yc6hNxYij6+yHXSrBhJovo4IQlHC/UxTz/Nub554/8i05O5sf6wq5hDuKyXc3WKKcfpk2SR7Ne6X2qIOmxOMjZu/SR3e+n1E9r6yVpPU= Received: from [127.0.0.1] (69.181.140.208) by DM5PR15MB1515.namprd15.prod.outlook.com (10.173.225.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Sun, 3 Sep 2017 19:55:18 +0000 MIME-Version: 1.0 Subject: [PATCH] dagop: fix docstring of `cutfunc` X-Mercurial-Node: 75cb2afd931082496524b47b7dc0f34204b77292 X-Mercurial-Series-Index: 1 X-Mercurial-Series-Total: 1 Message-ID: <75cb2afd931082496524.1504468491@x1c> X-Mercurial-Series-Id: <75cb2afd931082496524.1504468491@x1c> User-Agent: Mercurial-patchbomb/4.2.3+1702-50a50b0a359a Date: Sun, 3 Sep 2017 12:54:51 -0700 From: Jun Wu <quark@fb.com> To: <mercurial-devel@mercurial-scm.org> X-Originating-IP: [69.181.140.208] X-ClientProxiedBy: SN2PR01CA0005.prod.exchangelabs.com (10.167.12.143) To DM5PR15MB1515.namprd15.prod.outlook.com (10.173.225.148) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e26bf2e-db0c-4f3f-71cd-08d4f305b43f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR15MB1515; X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1515; 3:uacRIsWuqdwhAnZlQ5mPMudAE8k2eHB0/xzU7j6OVvzRugs1K7/lZsd15nSEsTruW6ORW/DUJzXLNs8tda3mPMqC/P9XTXSZE7gXZhelwCGd270penCc58Y/FkNvMdZh9bQGal793OmBNuWd8y3fG7AmIM28mCtCTNt+Dh0lLEJG/kjUjCPHVx0ygxgMTWk7RGhYOgzRKLjK0uofeUI9bQbPyK0ujSCUc94pucLGqYR+/UkT6QnYZU5PpHhxxRry; 25:pN7M/Lr0s3+TeUkbUtIOSPZ7gReO84UxgzoqL3IlYYBdlQFMlwdJE/rqthg7mpu3E4fAsaiSWb5aDgxBcJ/6z8Fs4kLszUN7Q8+DC9HqXm7137EY2RjOhe9w2pC19thgWWe2EQVQ5wWJuE1HvBhPv26uU55qph3O51K/I4RW7Kii4Nn654HvQkBEjus1lsed7aNl+utaLvX1xgO4jR0P0zG84YtD3u7bv/ZiwtjrN9eeQ1LV7r5GwuAw95fmQ/3nv7o9OAqh5oi8G/Rd4gplvvNxUpSI88C0FzGY+K77nxlWnqh0eVh02vJVos5gXULAshmfskwuTVcrQGT3NoeVCg==; 31:k2nDqeJ6+jE+18eEHGGZChSWFDp5dgshZq8KhYP/WmYBgLaJ+eZGg5kj87GPMClLaIK+BDNXnF/ybuFDmzaqiCliM0EsSHN+NBidpYGrFobZjrAqVnaIWcqdO8ZWA2B8AzOWDj3dsZcS/oxhjpUObABdVIcl422Vje5I+jpfiU+KF6KAR3wYD/vJYglZZxYKSok1FvlMjunrLdFX+dI6QlNYYo0CXFFGRCKojpNvG+4= X-MS-TrafficTypeDiagnostic: DM5PR15MB1515: X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1515; 20:jaO5piPQspZRQiQIGlqOZJL0yvF8pwCr84+qtqyjnSsCbQx++6kpkF2XdBmWJZPTzaxEYrM+LP9+BkWiDwVvYD7Y2GWL+pL9wet7t5Ousb6LxmvdzVoVYX+BDft4Fr6ymPhcbppo6vmKwoDqPHNzJrFixIC9JZAtdz3edjQ4xXwgZQnM1EQS1LzrL2iRuRP6yyDqQV9krlMTXfptvUHyl+3YlSjT4rlazZyzhZuULiX60W/jUwcPu8pTCem3lgVyEqQJwGfVBb5RRKyAU5V8WUX59jmhy+kE1J9WwgeyHkGfMEYrb72OcPnQERy2Y+T0n0fcpIvOR/iYUJQWVc8GXvFJfpO8CrBUZpqOWAo58eC72KiQ2vLiX162ljusgq2O638xrEarEos89twOza1HxRY64IiDKPy1676HOekEBKIs27bxDbLhstmUDGlprkNoNe7m1hYxmzMLU0L2OtRSZsmvxnwWFPpXUrYGoAPNJPN6jFR9P8UGXDKIohJ3B4FK; 4:XYIVtbHaCsqRd8vJUA3BHr7bQB7U4NY/J6TYnpiLkM8oYHDI2LjAQrjPnvEaunVyONAARwBuGKyCkW1eS1aK/UwDFm6I3a1H5t1EII7iXPhpZoMbzx0a6rj4prBUztGXwJUIhLdYaPIb/vaa/ileUrVUYio25kRU+giexil9YCTWXC1ilAVsQoMBG65ekOHTEo1C5YrFf2tiFrCI79OTUHreMmmfT8V7IMdmh0R9fsL1XXxtCdmmRgaDR5MVmTdD1b8GFK7D3HpP9vLMvfhI7H9/qK7AH+jFGs+bZYYpc/E= X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Microsoft-Antispam-PRVS: <DM5PR15MB1515434B39F94B0B0DB8CDA7CD900@DM5PR15MB1515.namprd15.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR15MB1515; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR15MB1515; X-Forefront-PRVS: 041963B986 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(6009001)(199003)(189002)(189998001)(47776003)(66066001)(50986999)(101416001)(305945005)(33716001)(6666003)(7736002)(5660300001)(8676002)(33646002)(54356999)(50466002)(2906002)(110136004)(6916009)(105586002)(4001350100001)(97736004)(42186005)(2361001)(2351001)(106356001)(97756001)(23726003)(3846002)(6116002)(83506001)(25786009)(81166006)(77096006)(8936002)(6486002)(68736007)(81156014)(86362001)(478600001)(90366009)(575784001)(9686003)(53936002)(46406003)(230700001)(81973001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR15MB1515; H:[127.0.0.1]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR15MB1515; 23:hZMhPhHAXVP8Ypz8G77K5yNxadCezFmRrSFI5no4c?= =?us-ascii?Q?rDAO7qgcfSn790OQ0DMSuIn+zdh6Wjop24LYJ1hAcrb66jK3JGIQP2mHsJs7?= =?us-ascii?Q?W7Ta0ZbV+ZNByafbSeWz2sRZfzgegg5JDf7b+3TttdIe9klx6zCSZe3wQH4P?= =?us-ascii?Q?gUua61aWWAkzSWNCRRiYlJMtgARIjl9IN92tjvAu0ZCpnbZmfiqo0iS76Cf7?= =?us-ascii?Q?/tZSp6XJCIlgxA9MRGLZ6Ys1Q5y4giFjekyPFN+CKvbJrPpr6p9rC31icTdS?= =?us-ascii?Q?sU5vaQP3Y12mXQv46x4jfJMufXcsQQRPNNzIozOxBis/Gd3jLFYsx8EFay1H?= =?us-ascii?Q?tg3rqP3ETdDIxB+ByxB2FtXIx2RnvYOZgid7s5TPbhECtp8HG3BaTo3HbGFM?= =?us-ascii?Q?VKNhjMZbzZFbqvAAgiKQpW3H3qKREH8UzfgmZEGW5ehcLV8BoPpigchGJwtT?= =?us-ascii?Q?50MXZgrVekaToHEgXxT4T2mcT/Iu8k4k1mPfIDZM9y9TwfHqOtQlY6A0SyED?= =?us-ascii?Q?BhHbn4+l7r/gKD3ToLlXJAluECf38mqWPWl51CHLESoEhiffWJmIOkiC25DD?= =?us-ascii?Q?wwZ4CM4HxdgtLcPPncHgIk9KgD+PhBtMCfqXoqX1nTXwvnS/qngbmybd10xc?= =?us-ascii?Q?A7TQWTgI10aOapsJG199vsbIi9KIxcLtyxkg0IMys2dqZXEOz8KInhu/XzTh?= =?us-ascii?Q?hvEgnfATj3Xi944xTnCmQX71AO4fGf6zVluQLXKNGMCP7wkZ2lwhpbpaHL+F?= =?us-ascii?Q?s8rNgB5rBAXii4AIRmpQKfLyZx/YRIxNeS9vt7SDdSeUIQwu7VBykAa6fh2b?= =?us-ascii?Q?E6qGaE82HQgn3C6OEiGKJ9sPgTzRw/IC6PPCY5c3RScMBxrVEHI/7OASFcxD?= =?us-ascii?Q?FyoI9J/tCTiKOEc0KA1tDEqLTKNm2wfyBCh4nxcfELuqaWGMRMY5gN/oTn7Z?= =?us-ascii?Q?Is4eCAFnf7CQKndvqzxCt6wTgTzub0sCuetYpUmpWFngBOZzx+k+BUUAXz0w?= =?us-ascii?Q?15yf5XyqHl590YkqcLcZXdrB5Gxl5WoN1JDo5r+TeaKHbiTRVJkmiXzyXv2s?= =?us-ascii?Q?EUMPuxoOU38ha77x23O6mInT1tJRp8wDmPsx+j7sWXD6XwSk/wo7SDVbYV5n?= =?us-ascii?Q?8fqb3UlPfvNL94UElDllkmJhopx98DDFrCfLkHS2YW3S/hWmWEbMQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1515; 6:tdmgR+LFLp1fjK0mb3DjiTFnSzm3zJQXQu4+BV/u8qA0k/6IWygntcs986JfQ+W6EZYbVg0GF8iRua02jtcD6oTBCUtMF2ekSr31TytImHhU2HKtLLCtwp2Ars7YxBOi6yCJ2bufmzIW8uND/hrk8iyiiWEdeYxhdTvC6kY1TQ+HysXi8zwaIacZsifv0JzTUkI54wPYiAbVKl8Qs/W1asJq1TDlAaEMEivLTNyyAbrnpEEEjYipiSLTBelK5PqU0vcYEYgM/WWGXxWIlMspK1fC/dmYW847zIX1Ow7DXTCdVrx6/Ib9Z/EcaiYJV8BhfRWqXk4AiK1UTEQi34mNgg==; 5:t36dAslNippEjwry4eRe3K6O84d8Oqv9peDhSWZc4p8bly7aDbJDYdUyBsyZvwpOFtOrdWZLBh409vZr3NyVC2KAXz445l/yj12ZrgS5qcXnLPaY80X3ktvtL0zvv+HparZBAs2ApoLjBEL6JGK6mg==; 24:w2mh0Yv2DwGvujBon/1kTOkJ/KdR/rzHIsFicbqva5Q6YZ7+9qL90ulAPW34Ne0Cgjyvyxy4YkN+EJbNZMRiPGULfFP9vVHxtbnDFNQpbu0=; 7:ex/bQVAUqMzeI2loX8TywJ42pPVUaTooU0pmNU/UbwGsXeOxYwV+aFWyQe4N9U4e1RNPyi+aah5/t/66ECRgFiDr6R2oxWHXosZcEGWlBYKJ2R8fw41XJS3FWXGzJFfcU1JHjOnf8ShIZXbWav+uUm2IHThZ8ly2iAV6MdkyVb00A0y2bHU1MEVXqcDqdAAM3t2ZGz/m1fh8asip4cm60iryqXhzJnsGYmogAhEV4NU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1515; 20:TUSXxVYB2dW6CAAT0t3ElWOLebf5G8pEE3Djp9pWsZoHgQDGMuA+yMqtZhnTetlA02uutvL8uPTM1rT05F2HZJgxBSeNl0DGHXMhYxheg0XUM0B//I0DjGoa2LHwjDzMqhDlZBAM/fauWbmDUVlBvTmTFNBqOkmu9SQM8nnq7N0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2017 19:55:18.6931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1515 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-09-03_05:, , signatures=0 X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Jun Wu - Sept. 3, 2017, 7:54 p.m.
Yuya Nishihara - Sept. 4, 2017, 1:01 p.m.
On Sun, 3 Sep 2017 12:54:51 -0700, Jun Wu wrote: > # HG changeset patch > # User Jun Wu <quark@fb.com> > # Date 1504468483 25200 > # Sun Sep 03 12:54:43 2017 -0700 > # Node ID 75cb2afd931082496524b47b7dc0f34204b77292 > # Parent 68afb88b51bb626cd25440e2df812f2306463b55 > dagop: fix docstring of `cutfunc` > > I was using `keepfunc`, then found `cutfunc` easier to understand. But > forgot to update the documentation. This patch fixes it. > > Maybe it could be applied in-place. Folded this as c6c8a52e28c9, thanks.
Patch
diff --git a/mercurial/dagop.py b/mercurial/dagop.py --- a/mercurial/dagop.py +++ b/mercurial/dagop.py @@ -103,5 +103,5 @@ def revancestors(repo, revs, followfirst If cutfunc is provided, it will be used to cut the traversal of the DAG. - When cutfunc(X) returns False, the DAG traversal stops - revision X and + When cutfunc(X) returns True, the DAG traversal stops - revision X and X's ancestors in the traversal path will be skipped. This could be an optimization sometimes.