Patchwork [1,of,2] rebase: drop unused 'rebaserevs' argument from _handleskippingobsolete()

login
register
mail settings
Submitter Denis Laxalde
Date Aug. 30, 2017, 1:54 p.m.
Message ID <28e449777fb7452e5692.1504101254@marimba>
Download mbox | patch
Permalink /patch/23507/
State Changes Requested
Headers show

Comments

Denis Laxalde - Aug. 30, 2017, 1:54 p.m.
# HG changeset patch
# User Denis Laxalde <denis@laxalde.org>
# Date 1504019630 -7200
#      Tue Aug 29 17:13:50 2017 +0200
# Node ID 28e449777fb7452e569292184a18f358186248a3
# Parent  088598153aa28a1c65e9757dd52cfc406a330156
rebase: drop unused 'rebaserevs' argument from _handleskippingobsolete()

Patch

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -267,10 +267,9 @@  class rebaseruntime(object):
         self.external = external
         self.activebookmark = activebookmark
 
-    def _handleskippingobsolete(self, rebaserevs, obsoleterevs, dest):
+    def _handleskippingobsolete(self, obsoleterevs, dest):
         """Compute structures necessary for skipping obsolete revisions
 
-        rebaserevs:     iterable of all revisions that are to be rebased
         obsoleterevs:   iterable of all obsolete revisions in rebaseset
         dest:           a destination revision for the rebase operation
         """
@@ -317,7 +316,7 @@  class rebaseruntime(object):
                 hint=_('use --keep to keep original changesets'))
 
         obsrevs = _filterobsoleterevs(self.repo, set(rebaseset))
-        self._handleskippingobsolete(rebaseset, obsrevs, dest.rev())
+        self._handleskippingobsolete(obsrevs, dest.rev())
 
         result = buildstate(self.repo, dest, rebaseset, self.collapsef,
                             self.obsoletenotrebased)