From patchwork Sun Aug 27 12:33:58 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D492: context: remove unnecessary default values for matchers (API)
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 23375
Message-Id: <1c07a524a55aa85ca71ac6b027541f08@localhost.localdomain>
To: mercurial-devel@mercurial-scm.org
Date: Sun, 27 Aug 2017 12:33:58 +0000

This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe43264525ce5: context: remove unnecessary default values for matchers (API) (authored by martinvonz).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D492?vs=1243&id=1328

REVISION DETAIL
  https://phab.mercurial-scm.org/D492

AFFECTED FILES
  mercurial/context.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers, dsp
Cc: dsp, mercurial-devel

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -1750,11 +1750,9 @@
                 # Even if the wlock couldn't be grabbed, clear out the list.
                 self._repo.clearpostdsstatus()
 
-    def _dirstatestatus(self, match=None, ignored=False, clean=False,
-                        unknown=False):
+    def _dirstatestatus(self, match, ignored=False, clean=False, unknown=False):
         '''Gets the status from the dirstate -- internal use only.'''
         listignored, listclean, listunknown = ignored, clean, unknown
-        match = match or matchmod.always(self._repo.root, self._repo.getcwd())
         subrepos = []
         if '.hgsub' in self:
             subrepos = sorted(self.substate)
@@ -1980,14 +1978,12 @@
         super(workingctx, self).__init__(repo, text, user, date, extra,
                                          changes)
 
-    def _dirstatestatus(self, match=None, ignored=False, clean=False,
-                        unknown=False):
+    def _dirstatestatus(self, match, ignored=False, clean=False, unknown=False):
         """Return matched files only in ``self._status``
 
         Uncommitted files appear "clean" via this context, even if
         they aren't actually so in the working directory.
         """
-        match = match or matchmod.always(self._repo.root, self._repo.getcwd())
         if clean:
             clean = [f for f in self._manifest if f not in self._changedset]
         else: