Submitter | elson.wei@gmail.com |
---|---|
Date | Sept. 5, 2013, 1:28 a.m. |
Message ID | <3418b76aeb5c2f220201.1378344481@ElsonWei-NB.PrimeVOLT> |
Download | mbox | patch |
Permalink | /patch/2331/ |
State | Changes Requested |
Headers | show |
Comments
On 09/07/2013 07:12 AM, elson wrote: > May I know which test is fail? > I've run: python run-tests.py test-mq*.t > But I ran these 30 tests successful Perhaps try running the entire test suite?
I ran whole test suite. First time: 425 pass, 33 skipped and test-keyword.t fail. Then I ran test-keyword.t alone, It was pass. 2013/9/8 Siddharth Agarwal <sid0@fb.com> > On 09/07/2013 07:12 AM, elson wrote: > >> May I know which test is fail? >> I've run: python run-tests.py test-mq*.t >> But I ran these 30 tests successful >> > > Perhaps try running the entire test suite? >
Patch
diff --git a/hgext/mq.py b/hgext/mq.py --- a/hgext/mq.py +++ b/hgext/mq.py @@ -506,7 +506,8 @@ if not patchguards: return True, None guards = self.active() - exactneg = [g for g in patchguards if g[0] == '-' and g[1:] in guards] + neg = [g for g in patchguards if g[0] == '-'] + exactneg = [g for g in neg if g[1:] in guards] if exactneg: return False, repr(exactneg[0]) pos = [g for g in patchguards if g[0] == '+'] @@ -515,7 +516,7 @@ if exactpos: return True, repr(exactpos[0]) return False, ' '.join(map(repr, pos)) - return True, '' + return True, ' '.join(map(repr, neg)) def explainpushable(self, idx, all_patches=False): write = all_patches and self.ui.write or self.ui.warn