Patchwork [2,of,2] templatekw: specify plural form of instability

login
register
mail settings
Submitter Yuya Nishihara
Date Aug. 16, 2017, 5:22 a.m.
Message ID <50723ff5912ecde3f8e4.1502860931@mimosa>
Download mbox | patch
Permalink /patch/23068/
State Accepted
Headers show

Comments

Yuya Nishihara - Aug. 16, 2017, 5:22 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1502601148 -32400
#      Sun Aug 13 14:12:28 2017 +0900
# Node ID 50723ff5912ecde3f8e43bea4b84db03bae7f1f0
# Parent  6cd0eafbd52b4e0efcad037876dc9bdf6c9bbfbb
templatekw: specify plural form of instability

Follows up 40739aef97f7.
Boris Feld - Aug. 16, 2017, 8:48 a.m.
LGTM

On Wed, 2017-08-16 at 14:22 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1502601148 -32400
> #      Sun Aug 13 14:12:28 2017 +0900
> # Node ID 50723ff5912ecde3f8e43bea4b84db03bae7f1f0
> # Parent  6cd0eafbd52b4e0efcad037876dc9bdf6c9bbfbb
> templatekw: specify plural form of instability
> 
> Follows up 40739aef97f7.
> 
> diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py
> --- a/mercurial/templatekw.py
> +++ b/mercurial/templatekw.py
> @@ -783,7 +783,8 @@ def showinstabilities(**args):
>      (EXPERIMENTAL)
>      """
>      args = pycompat.byteskwargs(args)
> -    return showlist('instability', args['ctx'].instabilities(),
> args)
> +    return showlist('instability', args['ctx'].instabilities(),
> args,
> +                    plural='instabilities')
>  
>  # tell hggettext to extract docstrings from these functions:
>  i18nfunctions = keywords.values()
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Augie Fackler - Aug. 16, 2017, 6:28 p.m.
On Wed, Aug 16, 2017 at 02:22:11PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1502601148 -32400
> #      Sun Aug 13 14:12:28 2017 +0900
> # Node ID 50723ff5912ecde3f8e43bea4b84db03bae7f1f0
> # Parent  6cd0eafbd52b4e0efcad037876dc9bdf6c9bbfbb
> templatekw: specify plural form of instability

queued, thanks

Patch

diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py
--- a/mercurial/templatekw.py
+++ b/mercurial/templatekw.py
@@ -783,7 +783,8 @@  def showinstabilities(**args):
     (EXPERIMENTAL)
     """
     args = pycompat.byteskwargs(args)
-    return showlist('instability', args['ctx'].instabilities(), args)
+    return showlist('instability', args['ctx'].instabilities(), args,
+                    plural='instabilities')
 
 # tell hggettext to extract docstrings from these functions:
 i18nfunctions = keywords.values()