Patchwork D30: merge: Removed sorting in casefolding detection, for a slight performance win

login
register
mail settings
Submitter phabricator
Date Aug. 10, 2017, 1:12 p.m.
Message ID <98c6e6106dc21f204ec5f3a3208a1478@localhost.localdomain>
Download mbox | patch
Permalink /patch/22832/
State Not Applicable
Headers show

Comments

phabricator - Aug. 10, 2017, 1:12 p.m.
alex_gaynor updated this revision to Diff 737.
alex_gaynor added a comment.
Herald added a reviewer: hg-reviewers.


  Undo a change which was incorrect

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D30?vs=46&id=737

BRANCH
  performance-changes (bookmark) on default (branch)

REVISION DETAIL
  https://phab.mercurial-scm.org/D30

AFFECTED FILES
  mercurial/merge.py

CHANGE DETAILS




To: alex_gaynor, durin42, dsp, #hg-reviewers
Cc: quark, krbullock, dsp, mercurial-devel

Patch

diff --git a/mercurial/merge.py b/mercurial/merge.py
--- a/mercurial/merge.py
+++ b/mercurial/merge.py
@@ -753,7 +753,7 @@ 
 
     # check case-folding collision in provisional merged manifest
     foldmap = {}
-    for f in sorted(pmmf):
+    for f in pmmf:
         fold = util.normcase(f)
         if fold in foldmap:
             raise error.Abort(_("case-folding collision between %s and %s")