Patchwork [2,of,8] obsolete: add an explicit '_succs.copy()' method

login
register
mail settings
Submitter Boris Feld
Date Aug. 7, 2017, 2:56 p.m.
Message ID <be13b5fb2782b04b03d6.1502117781@FB>
Download mbox | patch
Permalink /patch/22725/
State Changes Requested
Headers show

Comments

Boris Feld - Aug. 7, 2017, 2:56 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1499044397 -7200
#      Mon Jul 03 03:13:17 2017 +0200
# Node ID be13b5fb2782b04b03d60a988ba306ba4a8d80bd
# Parent  a3797b722e73a1390d0dc8cb4c4630e4fe177919
# EXP-Topic obsfatetemplate
obsolete: add an explicit '_succs.copy()' method

Mimic the standard API for copying in the _succs class, it makes the code
slightly cleaner and will be needed later for copying markers at the same time
than copying the list content.

Patch

diff -r a3797b722e73 -r be13b5fb2782 mercurial/obsutil.py
--- a/mercurial/obsutil.py	Mon Jul 03 00:53:55 2017 +0200
+++ b/mercurial/obsutil.py	Mon Jul 03 03:13:17 2017 +0200
@@ -314,6 +314,9 @@ 
 class _succs(list):
     """small class to represent a successors with some metadata about it"""
 
+    def copy(self):
+        return _succs(self)
+
 def successorssets(repo, initialnode, closest=False, cache=None):
     """Return set of all latest successors of initial nodes
 
@@ -514,7 +517,7 @@ 
                         productresult = []
                         for prefix in markss:
                             for suffix in cache[suc]:
-                                newss = _succs(prefix)
+                                newss = prefix.copy()
                                 for part in suffix:
                                     # do not duplicated entry in successors set
                                     # first entry wins.