Submitter | phabricator |
---|---|
Date | Aug. 4, 2017, 3:13 a.m. |
Message ID | <differential-rev-PHID-DREV-ioyv7xpseiobcjw53fyo-req@phab.mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/22663/ |
State | Superseded |
Headers | show |
Comments
martinvonz added a comment. I'd guess it's because it was evaluated before the __version__.py file existed before this change, not dependent on directories. So the fix looks good, but I suspect the commit message should be updated. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D224 To: rdamazio, #hg-reviewers Cc: martinvonz, mercurial-devel
rdamazio added a comment. Updated description REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D224 To: rdamazio, #hg-reviewers Cc: martinvonz, mercurial-devel
Patch
diff --git a/Makefile b/Makefile --- a/Makefile +++ b/Makefile @@ -186,7 +186,7 @@ PREFIX=/usr/local \ clean install mkdir -p $${OUTPUTDIR:-dist} - HGVER=$(shell python contrib/genosxversion.py $(OSXVERSIONFLAGS) build/mercurial/Library/Python/2.7/site-packages/mercurial/__version__.py ) && \ + HGVER=$$(shell python contrib/genosxversion.py $(OSXVERSIONFLAGS) build/mercurial/Library/Python/2.7/site-packages/mercurial/__version__.py ) && \ OSXVER=$$(sw_vers -productVersion | cut -d. -f1,2) && \ pkgbuild --filter \\.DS_Store --root build/mercurial/ \ --identifier org.mercurial-scm.mercurial \