Patchwork D171: phabricator: include the suggested arc config in the repo

login
register
mail settings
Submitter phabricator
Date July 21, 2017, 2:23 p.m.
Message ID <differential-rev-PHID-DREV-73k6lmui4heac5b7inqq-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/22539/
State Superseded, archived
Headers show

Comments

phabricator - July 21, 2017, 2:23 p.m.
alex_gaynor created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

TEST PLAN
  I uploaded this revision with `arc diff`

REPOSITORY
  rHG Mercurial

BRANCH
  arcconfig (bookmark) on stable (branch)

REVISION DETAIL
  https://phab.mercurial-scm.org/D171

AFFECTED FILES
  .arcconfig

CHANGE DETAILS




EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: alex_gaynor, durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - July 25, 2017, 1:16 a.m.
durin42 accepted this revision as: durin42.
durin42 added subscribers: durham, quark.
durin42 added a comment.


  This looks fine to me, but I also have no idea what I'm doing. I'd appreciate someone with more arc experience letting me know if  "history.immutable" : false being missing from the included-in-repo arcconfig will be a burden on those of us that have history mutation enabled...
  
  @durham @quark

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D171

To: alex_gaynor, durin42, #hg-reviewers
Cc: quark, durham, mercurial-devel
phabricator - July 25, 2017, 1:42 a.m.
simpkins accepted this revision.
simpkins added a comment.


  This looks good to me too.
  
  Personally I would vote for setting `history.immutable` to `false` too.  This mostly affects the behavior of the `arc diff` and `arc amend` commands.  This probably won't matter at all for people that submit diffs using the `phabsend` extension instead of `arc diff`.
  When set to false, `arc diff` will rewrite your local commit message to include the differential revision ID when submitting a diff.  `arc amend` will update your commit message to add a `Reviewed By` line once your diff has been accepted.
  Personally I find it useful to have this information in my local commit messages.  (The `phabdiff` and `phabstatus` extensions in the rFBHGEXT repository can also report some useful information if they find this field present in your commit message.)
  
  The only downside of leaving `history.immutable` as `true` is that you don't get this information in your commit message when running `arc diff` / `arc amend`; it shouldn't impact any other behavior.
  One arguable downside of setting `history.immutable` to `false` is that your local commit IDs do change after running `arc diff` or `arc amend` if it needed to update your commit message.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D171

To: alex_gaynor, durin42, #hg-reviewers, simpkins
Cc: simpkins, quark, durham, mercurial-devel

Patch

diff --git a/.arcconfig b/.arcconfig
new file mode 100644
--- /dev/null
+++ b/.arcconfig
@@ -0,0 +1,6 @@ 
+{
+    "conduit_uri": "https://phab.mercurial-scm.org/api",
+    "repository.callsign": "HG",
+    "arc.land.onto.default": "@",
+    "base": "hg:.^"
+}