Patchwork [1,of,3] test-phases-exchange: properly conditionalize output

login
register
mail settings
Submitter Yuya Nishihara
Date July 18, 2017, 2:47 p.m.
Message ID <20170718234731.026373c7c51f9e37e718fe13@tcha.org>
Download mbox | patch
Permalink /patch/22490/
State Not Applicable
Headers show

Comments

Yuya Nishihara - July 18, 2017, 2:47 p.m.
On Tue, 18 Jul 2017 23:32:14 +0900, Yuya Nishihara wrote:
> On Tue, 18 Jul 2017 08:51:18 -0400, Matt Harbison wrote:
> > # HG changeset patch
> > # User Matt Harbison <matt_harbison@yahoo.com>
> > # Date 1500380050 14400
> > #      Tue Jul 18 08:14:10 2017 -0400
> > # Node ID 684787b859b507ffa4a42baf6e453f14c6eb6352
> > # Parent  7733525d160cbf6395d63fc8a62b56760e75b06b
> > test-phases-exchange: properly conditionalize output
> 
> I'm not 100% sure about the run-tests changes, but they smell good.
> Queued, thanks.

Nah, got test failure. I took only the first patch.
Matt Harbison - July 19, 2017, 12:14 a.m.
On Tue, 18 Jul 2017 10:47:31 -0400, Yuya Nishihara <yuya@tcha.org> wrote:

> On Tue, 18 Jul 2017 23:32:14 +0900, Yuya Nishihara wrote:
>> On Tue, 18 Jul 2017 08:51:18 -0400, Matt Harbison wrote:
>> > # HG changeset patch
>> > # User Matt Harbison <matt_harbison@yahoo.com>
>> > # Date 1500380050 14400
>> > #      Tue Jul 18 08:14:10 2017 -0400
>> > # Node ID 684787b859b507ffa4a42baf6e453f14c6eb6352
>> > # Parent  7733525d160cbf6395d63fc8a62b56760e75b06b
>> > test-phases-exchange: properly conditionalize output
>>
>> I'm not 100% sure about the run-tests changes, but they smell good.
>> Queued, thanks.
>
> Nah, got test failure. I took only the first patch.

Sorry about that.  I didn't have time for a full Linux run after the  
Windows run.  What's happening is '*/missing/..' is optional, but matches  
'/missing/..', and consumes the output.  Then there's no output left for  
the required next line.  I'll adjust the test, and think about making  
(feature !) lines ignored instead of optional when the feature isn't  
supported next cycle.

> --- /home/yuya/work/hghacks/mercurial-review-run/tests/test-https.t
> +++ /home/yuya/work/hghacks/mercurial-review-run/tests/test-https.t.err
> @@ -606,13 +606,11 @@
>    $ hg serve -p $HGPORT --certificate=/missing/certificate \
>    > --config devel.servercafile=$PRIV --config  
> devel.serverrequirecert=true
>    abort: referenced certificate file (*/missing/certificate) does not  
> exist (glob) (windows !)
> -  abort: referenced certificate file (/missing/certificate) does not  
> exist (no-windows !)
>    [255]
>   $ hg serve -p $HGPORT --certificate=$PRIV \
>    > --config devel.servercafile=/missing/cafile --config  
> devel.serverrequirecert=true
>    abort: referenced certificate file (*/missing/cafile) does not exist  
> (glob) (windows !)
> -  abort: referenced certificate file (/missing/cafile) does not exist  
> (no-windows !)
>    [255]
> Start hgweb that requires client certificates:
> @@ -657,13 +655,11 @@
>   $ hg id https://localhost:$HGPORT/ --config auth.l.cert=/missing/cert
>    abort: certificate file (*/missing/cert) does not exist; cannot  
> connect to localhost (glob) (windows !)
> -  abort: certificate file (/missing/cert) does not exist; cannot  
> connect to localhost (no-windows !)
>    (restore missing file or fix references in Mercurial config)
>    [255]
>   $ hg id https://localhost:$HGPORT/ --config auth.l.key=/missing/key
>    abort: certificate file (*/missing/key) does not exist; cannot  
> connect to localhost (glob) (windows !)
> -  abort: certificate file (/missing/key) does not exist; cannot connect  
> to localhost (no-windows !)
>    (restore missing file or fix references in Mercurial config)
>    [255]
Augie Fackler - July 25, 2017, 1:35 a.m.
On Tue, Jul 18, 2017 at 08:14:34PM -0400, Matt Harbison wrote:
> On Tue, 18 Jul 2017 10:47:31 -0400, Yuya Nishihara <yuya@tcha.org> wrote:
>
> > On Tue, 18 Jul 2017 23:32:14 +0900, Yuya Nishihara wrote:
> > > On Tue, 18 Jul 2017 08:51:18 -0400, Matt Harbison wrote:
> > > > # HG changeset patch
> > > > # User Matt Harbison <matt_harbison@yahoo.com>
> > > > # Date 1500380050 14400
> > > > #      Tue Jul 18 08:14:10 2017 -0400
> > > > # Node ID 684787b859b507ffa4a42baf6e453f14c6eb6352
> > > > # Parent  7733525d160cbf6395d63fc8a62b56760e75b06b
> > > > test-phases-exchange: properly conditionalize output
> > >
> > > I'm not 100% sure about the run-tests changes, but they smell good.
> > > Queued, thanks.
> >
> > Nah, got test failure. I took only the first patch.
>
> Sorry about that.  I didn't have time for a full Linux run after the Windows
> run.

Mercurial contributors are welcome to use
https://gcc.gnu.org/wiki/CompileFarm#How_to_Get_Involved.3F for
running tests. One of the machines there can run the tests in only a
couple of minutes, in case that's appealing.

Patch

--- /home/yuya/work/hghacks/mercurial-review-run/tests/test-https.t
+++ /home/yuya/work/hghacks/mercurial-review-run/tests/test-https.t.err
@@ -606,13 +606,11 @@ 
   $ hg serve -p $HGPORT --certificate=/missing/certificate \
   > --config devel.servercafile=$PRIV --config devel.serverrequirecert=true
   abort: referenced certificate file (*/missing/certificate) does not exist (glob) (windows !)
-  abort: referenced certificate file (/missing/certificate) does not exist (no-windows !)
   [255]
 
   $ hg serve -p $HGPORT --certificate=$PRIV \
   > --config devel.servercafile=/missing/cafile --config devel.serverrequirecert=true
   abort: referenced certificate file (*/missing/cafile) does not exist (glob) (windows !)
-  abort: referenced certificate file (/missing/cafile) does not exist (no-windows !)
   [255]
 
 Start hgweb that requires client certificates:
@@ -657,13 +655,11 @@ 
 
   $ hg id https://localhost:$HGPORT/ --config auth.l.cert=/missing/cert
   abort: certificate file (*/missing/cert) does not exist; cannot connect to localhost (glob) (windows !)
-  abort: certificate file (/missing/cert) does not exist; cannot connect to localhost (no-windows !)
   (restore missing file or fix references in Mercurial config)
   [255]
 
   $ hg id https://localhost:$HGPORT/ --config auth.l.key=/missing/key
   abort: certificate file (*/missing/key) does not exist; cannot connect to localhost (glob) (windows !)
-  abort: certificate file (/missing/key) does not exist; cannot connect to localhost (no-windows !)
   (restore missing file or fix references in Mercurial config)
   [255]