Patchwork [9,of,9] color: drop the now useless color extension

login
register
mail settings
Submitter Boris Feld
Date July 15, 2017, 6:41 p.m.
Message ID <bb3703129b5035a162fd.1500144072@FB>
Download mbox | patch
Permalink /patch/22413/
State Accepted
Headers show

Comments

Boris Feld - July 15, 2017, 6:41 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1500121055 -7200
#      Sat Jul 15 14:17:35 2017 +0200
# Node ID bb3703129b5035a162fd8ad8eee364295b9ce9d0
# Parent  f170c4ba9c21f40248b83b511e064474080a0060
# EXP-Topic cleanup.color
color: drop the now useless color extension

all the extension features are provided by core since 4.2.
Sean Farley - July 16, 2017, 10:27 p.m.
Boris Feld <boris.feld@octobus.net> writes:

> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1500121055 -7200
> #      Sat Jul 15 14:17:35 2017 +0200
> # Node ID bb3703129b5035a162fd8ad8eee364295b9ce9d0
> # Parent  f170c4ba9c21f40248b83b511e064474080a0060
> # EXP-Topic cleanup.color
> color: drop the now useless color extension
>
> all the extension features are provided by core since 4.2.

Not sure we should drop this so soon. I'll defer on this one since it's
close to the freeze (and there's no harm leaving it in).
David Demelier - July 17, 2017, 4:40 a.m.
And what about our strong backward compatibility?
David Demelier - July 17, 2017, 12:44 p.m.
2017-07-17 6:40 GMT+02:00 David Demelier <demelier.david@gmail.com>:
> And what about our strong backward compatibility?

Ignore my mail, I thought having a stale 'color =' in the hgrc would
cause an error.

I also vote for removal then.

Regards,
Augie Fackler - July 17, 2017, 2:01 p.m.
On Sun, Jul 16, 2017 at 03:27:31PM -0700, Sean Farley wrote:
>
> Boris Feld <boris.feld@octobus.net> writes:
>
> > # HG changeset patch
> > # User Boris Feld <boris.feld@octobus.net>
> > # Date 1500121055 -7200
> > #      Sat Jul 15 14:17:35 2017 +0200
> > # Node ID bb3703129b5035a162fd8ad8eee364295b9ce9d0
> > # Parent  f170c4ba9c21f40248b83b511e064474080a0060
> > # EXP-Topic cleanup.color
> > color: drop the now useless color extension
> >
> > all the extension features are provided by core since 4.2.
>
> Not sure we should drop this so soon. I'll defer on this one since it's
> close to the freeze (and there's no harm leaving it in).

Eh, it's dropping a noop in the way we've dropped other dead
extensions, it's relatively low risk. We can always back it out in the
unlikely event we see a problem.

Queued.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Sean Farley - July 17, 2017, 5:47 p.m.
Augie Fackler <raf@durin42.com> writes:

> On Sun, Jul 16, 2017 at 03:27:31PM -0700, Sean Farley wrote:
>>
>> Boris Feld <boris.feld@octobus.net> writes:
>>
>> > # HG changeset patch
>> > # User Boris Feld <boris.feld@octobus.net>
>> > # Date 1500121055 -7200
>> > #      Sat Jul 15 14:17:35 2017 +0200
>> > # Node ID bb3703129b5035a162fd8ad8eee364295b9ce9d0
>> > # Parent  f170c4ba9c21f40248b83b511e064474080a0060
>> > # EXP-Topic cleanup.color
>> > color: drop the now useless color extension
>> >
>> > all the extension features are provided by core since 4.2.
>>
>> Not sure we should drop this so soon. I'll defer on this one since it's
>> close to the freeze (and there's no harm leaving it in).
>
> Eh, it's dropping a noop in the way we've dropped other dead
> extensions, it's relatively low risk. We can always back it out in the
> unlikely event we see a problem.
>
> Queued.

Fair enough :-)

Patch

diff -r f170c4ba9c21 -r bb3703129b50 hgext/color.py
--- a/hgext/color.py	Sat Jul 15 14:16:54 2017 +0200
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,25 +0,0 @@ 
-# color.py color output for Mercurial commands
-#
-# Copyright (C) 2007 Kevin Christen <kevin.christen@gmail.com>
-#
-# This software may be used and distributed according to the terms of the
-# GNU General Public License version 2 or any later version.
-
-'''enable Mercurial color mode (DEPRECATED)
-
-This extension enables Mercurial color mode. The feature is now directly
-available in Mercurial core. You can access it using::
-
-  [ui]
-  color = auto
-
-See :hg:`help color` for details.
-'''
-
-from __future__ import absolute_import
-
-# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
-# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
-# be specifying the version(s) of Mercurial they are tested with, or
-# leave the attribute unspecified.
-testedwith = 'ships-with-hg-core'
diff -r f170c4ba9c21 -r bb3703129b50 mercurial/extensions.py
--- a/mercurial/extensions.py	Sat Jul 15 14:16:54 2017 +0200
+++ b/mercurial/extensions.py	Sat Jul 15 14:17:35 2017 +0200
@@ -32,6 +32,7 @@ 
 _builtin = {
     'hbisect',
     'bookmarks',
+    'color',
     'parentrevspec',
     'progress',
     'interhg',