Patchwork [1,of,3] filterpyflakes: move self-test into test file

login
register
mail settings
Submitter Augie Fackler
Date July 7, 2017, 7:17 p.m.
Message ID <6b6be532c678c9e79324.1499455024@imladris.local>
Download mbox | patch
Permalink /patch/22116/
State Accepted
Headers show

Comments

Augie Fackler - July 7, 2017, 7:17 p.m.
# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1499454456 14400
#      Fri Jul 07 15:07:36 2017 -0400
# Node ID 6b6be532c678c9e7932476cb0350b0e10b9fb194
# Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
filterpyflakes: move self-test into test file

This will avoid a false positive on an upcoming check-code rule.

Patch

diff --git a/tests/filterpyflakes.py b/tests/filterpyflakes.py
--- a/tests/filterpyflakes.py
+++ b/tests/filterpyflakes.py
@@ -35,7 +35,3 @@  for line in sys.stdin:
 for line in lines:
     sys.stdout.write(line)
 print()
-
-# self test of "undefined name" detection
-if False:
-    print(undefinedname)
diff --git a/tests/test-check-pyflakes.t b/tests/test-check-pyflakes.t
--- a/tests/test-check-pyflakes.t
+++ b/tests/test-check-pyflakes.t
@@ -6,10 +6,16 @@ 
 run pyflakes on all tracked files ending in .py or without a file ending
 (skipping binary file random-seed)
 
+  $ cat > test.py <<EOF
+  > print(undefinedname)
+  > EOF
+  $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
+  test.py:1: undefined name 'undefinedname'
+  
+
   $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
   > -X hgext/fsmonitor/pywatchman \
   > -X mercurial/pycompat.py -X contrib/python-zstandard \
   > 2>/dev/null \
   > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
-  tests/filterpyflakes.py:41: undefined name 'undefinedname'