Patchwork [1,of,2] releasenotes: add import check for fuzzywuzzy

login
register
mail settings
Submitter Rishabh Madan
Date June 29, 2017, 10:57 p.m.
Message ID <9f7c675413ffce1497c7.1498777045@bunty>
Download mbox | patch
Permalink /patch/21845/
State Superseded
Headers show

Comments

Rishabh Madan - June 29, 2017, 10:57 p.m.
# HG changeset patch
# User Rishabh Madan <rishabhmadan96@gmail.com>
# Date 1498771803 -7200
#      Thu Jun 29 23:30:03 2017 +0200
# Node ID 9f7c675413ffce1497c7db3ff1495e4050b151d6
# Parent  eb4c49f55f1f0d7719f514c16bec54515eb54f62
releasenotes: add import check for fuzzywuzzy

This patch adds the has_fuzzywuzzy for import check of external dependency
fuzzywuzzy.
Yuya Nishihara - July 3, 2017, 1:19 p.m.
On Fri, 30 Jun 2017 00:57:25 +0200, Rishabh Madan wrote:
> # HG changeset patch
> # User Rishabh Madan <rishabhmadan96@gmail.com>
> # Date 1498771803 -7200
> #      Thu Jun 29 23:30:03 2017 +0200
> # Node ID 9f7c675413ffce1497c7db3ff1495e4050b151d6
> # Parent  eb4c49f55f1f0d7719f514c16bec54515eb54f62
> releasenotes: add import check for fuzzywuzzy

Looks good to me. Can you resend this with the patch which actually introduces
the fuzzywuzzy import?

Patch

diff -r eb4c49f55f1f -r 9f7c675413ff tests/hghave.py
--- a/tests/hghave.py	Sun Jun 25 22:30:14 2017 -0700
+++ b/tests/hghave.py	Thu Jun 29 23:30:03 2017 +0200
@@ -658,3 +658,12 @@ 
 @check("fsmonitor", "running tests with fsmonitor")
 def has_fsmonitor():
     return 'HGFSMONITOR_TESTS' in os.environ
+
+@check("fuzzywuzzy", "Fuzzy string matching library")
+def has_fuzzywuzzy():
+    try:
+        import fuzzywuzzy
+        fuzzywuzzy.fuzz
+        return True
+    except ImportError:
+        return False