Patchwork [8,of,9] config: register the 'devel.serverrequirecert' config

login
register
mail settings
Submitter Pierre-Yves David
Date June 29, 2017, 7:33 p.m.
Message ID <273de5653735bee42ccc.1498764785@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/21838/
State Accepted
Headers show

Comments

Pierre-Yves David - June 29, 2017, 7:33 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1498649548 -7200
#      Wed Jun 28 13:32:28 2017 +0200
# Node ID 273de5653735bee42ccc887204fc31c14abd79c6
# Parent  98715d9b700e2c281ada1b61369433bc19b4427b
# EXP-Topic config.register
# Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 273de5653735
config: register the 'devel.serverrequirecert' config
Yuya Nishihara - July 1, 2017, 3:25 a.m.
On Thu, 29 Jun 2017 21:33:05 +0200, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@octobus.net>
> # Date 1498649548 -7200
> #      Wed Jun 28 13:32:28 2017 +0200
> # Node ID 273de5653735bee42ccc887204fc31c14abd79c6
> # Parent  98715d9b700e2c281ada1b61369433bc19b4427b
> # EXP-Topic config.register
> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 273de5653735
> config: register the 'devel.serverrequirecert' config
> 
> diff --git a/mercurial/configitems.py b/mercurial/configitems.py
> --- a/mercurial/configitems.py
> +++ b/mercurial/configitems.py
> @@ -77,6 +77,9 @@ coreconfigitem('devel', 'servercafile',
>  coreconfigitem('devel', 'serverexactprotocol',
>      default='',
>  )
> +coreconfigitem('devel', 'serverrequirecert',
> +    default=None,

Perhaps this should be False?
Pierre-Yves David - July 1, 2017, 6:10 p.m.
On 07/01/2017 05:25 AM, Yuya Nishihara wrote:
> On Thu, 29 Jun 2017 21:33:05 +0200, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david@octobus.net>
>> # Date 1498649548 -7200
>> #      Wed Jun 28 13:32:28 2017 +0200
>> # Node ID 273de5653735bee42ccc887204fc31c14abd79c6
>> # Parent  98715d9b700e2c281ada1b61369433bc19b4427b
>> # EXP-Topic config.register
>> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 273de5653735
>> config: register the 'devel.serverrequirecert' config
>>
>> diff --git a/mercurial/configitems.py b/mercurial/configitems.py
>> --- a/mercurial/configitems.py
>> +++ b/mercurial/configitems.py
>> @@ -77,6 +77,9 @@ coreconfigitem('devel', 'servercafile',
>>   coreconfigitem('devel', 'serverexactprotocol',
>>       default='',
>>   )
>> +coreconfigitem('devel', 'serverrequirecert',
>> +    default=None,
> 
> Perhaps this should be False?

Yes it should, good catch, I'll send a follow-up soon™.

Cheers,

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -77,6 +77,9 @@  coreconfigitem('devel', 'servercafile',
 coreconfigitem('devel', 'serverexactprotocol',
     default='',
 )
+coreconfigitem('devel', 'serverrequirecert',
+    default=None,
+)
 coreconfigitem('patch', 'fuzz',
     default=2,
 )