Patchwork [1,of,9] smartset: fix default value of abstractsmartset.sort()

login
register
mail settings
Submitter Yuya Nishihara
Date June 25, 2017, 3:26 a.m.
Message ID <cbf00411cd3e5c2db0cc.1498361170@mimosa>
Download mbox | patch
Permalink /patch/21682/
State Accepted
Headers show

Comments

Yuya Nishihara - June 25, 2017, 3:26 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1498317288 -32400
#      Sun Jun 25 00:14:48 2017 +0900
# Node ID cbf00411cd3e5c2db0ccdf73aaa35ea965c36648
# Parent  46e820119f60abc88adc759c10663c2c54ee19b1
smartset: fix default value of abstractsmartset.sort()

It's unused, but it shouldn't lie.

Patch

diff --git a/mercurial/smartset.py b/mercurial/smartset.py
--- a/mercurial/smartset.py
+++ b/mercurial/smartset.py
@@ -117,7 +117,7 @@  class abstractsmartset(object):
         """reverse the expected iteration order"""
         raise NotImplementedError()
 
-    def sort(self, reverse=True):
+    def sort(self, reverse=False):
         """get the set to iterate in an ascending or descending order"""
         raise NotImplementedError()