Patchwork [4,of,6,v3] tests: enforce use of $PYTHON in tests

login
register
mail settings
Submitter Augie Fackler
Date June 20, 2017, 2:10 p.m.
Message ID <aca4e0d060caf2babc57.1497967839@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/21530/
State Accepted
Headers show

Comments

Augie Fackler - June 20, 2017, 2:10 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1497550959 14400
#      Thu Jun 15 14:22:39 2017 -0400
# Node ID aca4e0d060caf2babc579259e3d5a85f75518810
# Parent  395f5587885cfa3101c43dd76c4356e698aec472
tests: enforce use of $PYTHON in tests

Patch

diff --git a/tests/test-check-shbang.t b/tests/test-check-shbang.t
--- a/tests/test-check-shbang.t
+++ b/tests/test-check-shbang.t
@@ -5,9 +5,20 @@ 
 
 look for python scripts that do not use /usr/bin/env
 
-  $ hg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python")'
+  $ hg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t'
   [1]
 
+In tests, enforce $PYTHON and *not* /usr/bin/env python or similar:
+  $ hg files 'set:grep(r"#!.*?python") and **/*.t' \
+  > -X tests/test-check-execute.t \
+  > -X tests/test-check-module-imports.t \
+  > -X tests/test-check-pyflakes.t \
+  > -X tests/test-check-shbang.t
+  [1]
+
+The above exclusions are because they're looking for files that
+contain Python but don't end in .py - please avoid adding more.
+
 look for shell scripts that do not use /bin/sh
 
   $ hg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")'