Patchwork [1,of,2] test-logtoprocess: don't run on Windows

login
register
mail settings
Submitter Matt Harbison
Date June 20, 2017, 1:59 a.m.
Message ID <67a2a0b9a3bf90ecd4e8.1497923940@Envy>
Download mbox | patch
Permalink /patch/21518/
State Accepted
Headers show

Comments

Matt Harbison - June 20, 2017, 1:59 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1497923063 14400
#      Mon Jun 19 21:44:23 2017 -0400
# Node ID 67a2a0b9a3bf90ecd4e876cdd5f4f94b570314ee
# Parent  661025fd3e1cd5d5e2dee12b7f64312d6cd48a0b
test-logtoprocess: don't run on Windows

Several bits of output were missing[1], unless the DETACHED_PROCESS flag is
_not_ passed to subprocess.Popen().  The problem with that is it briefly opens
and closes several cmd.exe windows on screen.  Foozy also mentioned some other
issues in that thread.

With this, the last of the long standing Windows failures fixed, the test suite
now runs cleanly (536 ran, 67 skipped) on Windows 7 x64, with python 2.7.13. \o/

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096987.html
Gregory Szorc - June 20, 2017, 6:21 a.m.
On Mon, Jun 19, 2017 at 6:59 PM, Matt Harbison <mharbison72@gmail.com>
wrote:

> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1497923063 14400
> #      Mon Jun 19 21:44:23 2017 -0400
> # Node ID 67a2a0b9a3bf90ecd4e876cdd5f4f94b570314ee
> # Parent  661025fd3e1cd5d5e2dee12b7f64312d6cd48a0b
> test-logtoprocess: don't run on Windows
>

Queued these. Congratulations on the milestone!


>
> Several bits of output were missing[1], unless the DETACHED_PROCESS flag is
> _not_ passed to subprocess.Popen().  The problem with that is it briefly
> opens
> and closes several cmd.exe windows on screen.  Foozy also mentioned some
> other
> issues in that thread.
>
> With this, the last of the long standing Windows failures fixed, the test
> suite
> now runs cleanly (536 ran, 67 skipped) on Windows 7 x64, with python
> 2.7.13. \o/
>
> [1] https://www.mercurial-scm.org/pipermail/mercurial-devel/
> 2017-April/096987.html
>
> diff --git a/tests/test-logtoprocess.t b/tests/test-logtoprocess.t
> --- a/tests/test-logtoprocess.t
> +++ b/tests/test-logtoprocess.t
> @@ -1,3 +1,5 @@
> +#require no-windows
> +
>  ATTENTION: logtoprocess runs commands asynchronously. Be sure to append
> "| cat"
>  to hg commands, to wait for the output, if you want to test its output.
>  Otherwise the test will be flaky.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/tests/test-logtoprocess.t b/tests/test-logtoprocess.t
--- a/tests/test-logtoprocess.t
+++ b/tests/test-logtoprocess.t
@@ -1,3 +1,5 @@ 
+#require no-windows
+
 ATTENTION: logtoprocess runs commands asynchronously. Be sure to append "| cat"
 to hg commands, to wait for the output, if you want to test its output.
 Otherwise the test will be flaky.