Patchwork help: correct description of "glob:foo/*" matching

login
register
mail settings
Submitter via Mercurial-devel
Date June 12, 2017, 10:13 p.m.
Message ID <0a175f0a4a0f11e8d252.1497305621@martinvonz.svl.corp.google.com>
Download mbox | patch
Permalink /patch/21349/
State Accepted
Headers show

Comments

via Mercurial-devel - June 12, 2017, 10:13 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1497291861 25200
#      Mon Jun 12 11:24:21 2017 -0700
# Node ID 0a175f0a4a0f11e8d252f133fc19f8ba1a0298d3
# Parent  348b491c093401f849ea4c4106b164672efc6bed
help: correct description of "glob:foo/*" matching

Unlike what the description says, it does not match recursively. Also
add an example of "glob:foo/**" (which does match recursively).
Sean Farley - June 12, 2017, 10:31 p.m.
Martin von Zweigbergk via Mercurial-devel
<mercurial-devel@mercurial-scm.org> writes:

> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz@google.com>
> # Date 1497291861 25200
> #      Mon Jun 12 11:24:21 2017 -0700
> # Node ID 0a175f0a4a0f11e8d252f133fc19f8ba1a0298d3
> # Parent  348b491c093401f849ea4c4106b164672efc6bed
> help: correct description of "glob:foo/*" matching
>
> Unlike what the description says, it does not match recursively. Also
> add an example of "glob:foo/**" (which does match recursively).

I've gone ahead and queued this for stable since it's a doc fix. Thanks!

Patch

diff --git a/mercurial/help/patterns.txt b/mercurial/help/patterns.txt
--- a/mercurial/help/patterns.txt
+++ b/mercurial/help/patterns.txt
@@ -58,7 +58,8 @@ 
   *.c            any name ending in ".c" in the current directory
   **.c           any name ending in ".c" in any subdirectory of the
                  current directory including itself.
-  foo/*          any file in directory foo plus all its subdirectories,
+  foo/*          any file in directory foo
+  foo/**         any file in directory foo plus all its subdirectories,
                  recursively
   foo/*.c        any name ending in ".c" in the directory foo
   foo/**.c       any name ending in ".c" in any subdirectory of foo