Patchwork repoview: remove special casing of "requirements"

login
register
mail settings
Submitter Gregory Szorc
Date June 9, 2017, 6:28 a.m.
Message ID <e583b786ffba99cb775c.1496989694@ubuntu-vm-main>
Download mbox | patch
Permalink /patch/21272/
State Accepted
Headers show

Comments

Gregory Szorc - June 9, 2017, 6:28 a.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1496978893 25200
#      Thu Jun 08 20:28:13 2017 -0700
# Node ID e583b786ffba99cb775cf9d3a126cf50db74f85a
# Parent  e1a094a7815f3d906374ff2fe06296cbeaf89fcb
repoview: remove special casing of "requirements"

At the time this code was introduced (3a6ddacb7198), the inline comment
was true. This changed in e3a928bd1cd4. The proxy is no longer needed.
Pierre-Yves David - June 9, 2017, 9:37 a.m.
On 06/09/2017 07:28 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1496978893 25200
> #      Thu Jun 08 20:28:13 2017 -0700
> # Node ID e583b786ffba99cb775cf9d3a126cf50db74f85a
> # Parent  e1a094a7815f3d906374ff2fe06296cbeaf89fcb
> repoview: remove special casing of "requirements"
>
> At the time this code was introduced (3a6ddacb7198), the inline comment
> was true. This changed in e3a928bd1cd4. The proxy is no longer needed.

That change seems obviously right.
Augie Fackler - June 9, 2017, 6:08 p.m.
On Thu, Jun 08, 2017 at 11:28:14PM -0700, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1496978893 25200
> #      Thu Jun 08 20:28:13 2017 -0700
> # Node ID e583b786ffba99cb775cf9d3a126cf50db74f85a
> # Parent  e1a094a7815f3d906374ff2fe06296cbeaf89fcb
> repoview: remove special casing of "requirements"

queued, thanks

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -243,10 +243,3 @@  class repoview(object):
 
     def __delattr__(self, attr):
         return delattr(self._unfilteredrepo, attr)
-
-    # The `requirements` attribute is initialized during __init__. But
-    # __getattr__ won't be called as it also exists on the class. We need
-    # explicit forwarding to main repo here
-    @property
-    def requirements(self):
-        return self._unfilteredrepo.requirements