Patchwork [6,of,6,V2] py3: add test to show `hg update` and `hg identify` works on Python 3

login
register
mail settings
Submitter Pulkit Goyal
Date June 2, 2017, 8:46 a.m.
Message ID <33317f49a756894824cc.1496393171@workspace>
Download mbox | patch
Permalink /patch/21135/
State Accepted
Headers show

Comments

Pulkit Goyal - June 2, 2017, 8:46 a.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1496265079 -19800
#      Thu Jun 01 02:41:19 2017 +0530
# Node ID 33317f49a756894824ccc799efa0e7473aeb275c
# Parent  f6a8bfcf09665b66f0698c0a0f40d48212da9458
py3: add test to show `hg update` and `hg identify` works on Python 3
Boris Feld - June 2, 2017, 10:33 a.m.
I read the serie, it looks good!

I love the idea about the dict.update to avoid gc churns.

On Fri, 2017-06-02 at 14:16 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1496265079 -19800
> #      Thu Jun 01 02:41:19 2017 +0530
> # Node ID 33317f49a756894824ccc799efa0e7473aeb275c
> # Parent  f6a8bfcf09665b66f0698c0a0f40d48212da9458
> py3: add test to show `hg update` and `hg identify` works on Python 3
> 
> diff --git a/tests/test-py3-commands.t b/tests/test-py3-commands.t
> --- a/tests/test-py3-commands.t
> +++ b/tests/test-py3-commands.t
> @@ -222,3 +222,10 @@
>      "parents": ["0000000000000000000000000000000000000000"]
>     }
>    ]
> +
> +Show that update works now!
> +
> +  $ hg up 0
> +  0 files updated, 0 files merged, 1 files removed, 0 files
> unresolved
> +  $ hg identify
> +  71c96e924262
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Yuya Nishihara - June 2, 2017, 2:47 p.m.
On Fri, 02 Jun 2017 12:33:14 +0200, Boris Feld wrote:
> I read the serie, it looks good!
> 
> I love the idea about the dict.update to avoid gc churns.
> 
> On Fri, 2017-06-02 at 14:16 +0530, Pulkit Goyal wrote:
> > # HG changeset patch
> > # User Pulkit Goyal <7895pulkit@gmail.com>
> > # Date 1496265079 -19800
> > #      Thu Jun 01 02:41:19 2017 +0530
> > # Node ID 33317f49a756894824ccc799efa0e7473aeb275c
> > # Parent  f6a8bfcf09665b66f0698c0a0f40d48212da9458
> > py3: add test to show `hg update` and `hg identify` works on Python 3

Yeah, queued these, thanks.

Patch

diff --git a/tests/test-py3-commands.t b/tests/test-py3-commands.t
--- a/tests/test-py3-commands.t
+++ b/tests/test-py3-commands.t
@@ -222,3 +222,10 @@ 
     "parents": ["0000000000000000000000000000000000000000"]
    }
   ]
+
+Show that update works now!
+
+  $ hg up 0
+  0 files updated, 0 files merged, 1 files removed, 0 files unresolved
+  $ hg identify
+  71c96e924262