Patchwork [5,of,5,osx] tests: hint how to run slow tests when rejecting

login
register
mail settings
Submitter Augie Fackler
Date May 27, 2017, 12:27 a.m.
Message ID <e70c2a57c0d11f67f26e.1495844852@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/20952/
State Accepted
Headers show

Comments

Augie Fackler - May 27, 2017, 12:27 a.m.
# HG changeset patch
# User spectral <spectral@google.com>
# Date 1495835574 25200
#      Fri May 26 14:52:54 2017 -0700
# Node ID e70c2a57c0d11f67f26e5966dee9daf1e384acb2
# Parent  ffca36020b1032817a451e0fb752b80bbf55d84a
tests: hint how to run slow tests when rejecting
Jun Wu - May 27, 2017, 2:36 a.m.
Nice cleanup. Glad to see chg being included by default!

Excerpts from Augie Fackler's message of 2017-05-26 20:27:32 -0400:
> # HG changeset patch
> # User spectral <spectral@google.com>
> # Date 1495835574 25200
> #      Fri May 26 14:52:54 2017 -0700
> # Node ID e70c2a57c0d11f67f26e5966dee9daf1e384acb2
> # Parent  ffca36020b1032817a451e0fb752b80bbf55d84a
> tests: hint how to run slow tests when rejecting
> 
> diff --git a/tests/hghave.py b/tests/hghave.py
> --- a/tests/hghave.py
> +++ b/tests/hghave.py
> @@ -605,7 +605,7 @@ def has_pure():
>          os.environ.get("HGTEST_RUN_TESTS_PURE") == "--pure",
>      ])
>  
> -@check("slow", "allow slow tests")
> +@check("slow", "allow slow tests (use --allow-slow-tests)")
>  def has_slow():
>      return os.environ.get('HGTEST_SLOW') == 'slow'
>  
> diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
> --- a/tests/test-run-tests.t
> +++ b/tests/test-run-tests.t
> @@ -555,7 +555,7 @@ timeouts
>    > cat test-timeout.t >> test-slow-timeout.t
>    $ rt --timeout=1 --slowtimeout=3 test-timeout.t test-slow-timeout.t
>    st
> -  Skipped test-slow-timeout.t: missing feature: allow slow tests
> +  Skipped test-slow-timeout.t: missing feature: allow slow tests (use --allow-slow-tests)
>    Failed test-timeout.t: timed out
>    # Ran 1 tests, 1 skipped, 0 warned, 1 failed.
>    python hash seed: * (glob)
> @@ -852,7 +852,7 @@ test support for --allow-slow-tests
>    > EOF
>    $ rt test-very-slow-test.t
>    s
> -  Skipped test-very-slow-test.t: missing feature: allow slow tests
> +  Skipped test-very-slow-test.t: missing feature: allow slow tests (use --allow-slow-tests)
>    # Ran 0 tests, 1 skipped, 0 warned, 0 failed.
>    $ rt $HGTEST_RUN_TESTS_PURE --allow-slow-tests test-very-slow-test.t
>    .
Yuya Nishihara - May 27, 2017, 1:38 p.m.
On Fri, 26 May 2017 19:36:12 -0700, Jun Wu wrote:
> Nice cleanup. Glad to see chg being included by default!

Queued per Jun's review, thanks.

> Excerpts from Augie Fackler's message of 2017-05-26 20:27:32 -0400:
> > # HG changeset patch
> > # User spectral <spectral@google.com>

I've updated this to 'Kyle Lippincott <spectral@google.com>'.

> > # Date 1495835574 25200
> > #      Fri May 26 14:52:54 2017 -0700
> > # Node ID e70c2a57c0d11f67f26e5966dee9daf1e384acb2
> > # Parent  ffca36020b1032817a451e0fb752b80bbf55d84a
> > tests: hint how to run slow tests when rejecting

Patch

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -605,7 +605,7 @@  def has_pure():
         os.environ.get("HGTEST_RUN_TESTS_PURE") == "--pure",
     ])
 
-@check("slow", "allow slow tests")
+@check("slow", "allow slow tests (use --allow-slow-tests)")
 def has_slow():
     return os.environ.get('HGTEST_SLOW') == 'slow'
 
diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -555,7 +555,7 @@  timeouts
   > cat test-timeout.t >> test-slow-timeout.t
   $ rt --timeout=1 --slowtimeout=3 test-timeout.t test-slow-timeout.t
   st
-  Skipped test-slow-timeout.t: missing feature: allow slow tests
+  Skipped test-slow-timeout.t: missing feature: allow slow tests (use --allow-slow-tests)
   Failed test-timeout.t: timed out
   # Ran 1 tests, 1 skipped, 0 warned, 1 failed.
   python hash seed: * (glob)
@@ -852,7 +852,7 @@  test support for --allow-slow-tests
   > EOF
   $ rt test-very-slow-test.t
   s
-  Skipped test-very-slow-test.t: missing feature: allow slow tests
+  Skipped test-very-slow-test.t: missing feature: allow slow tests (use --allow-slow-tests)
   # Ran 0 tests, 1 skipped, 0 warned, 0 failed.
   $ rt $HGTEST_RUN_TESTS_PURE --allow-slow-tests test-very-slow-test.t
   .