Patchwork [6,of,6,V3] hidden: drop outdated comment about "dynamic" performance

login
register
mail settings
Submitter Pierre-Yves David
Date May 26, 2017, 6:34 p.m.
Message ID <6cc1cfd2eaeb90865e03.1495823690@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/20937/
State Accepted
Headers show

Comments

Pierre-Yves David - May 26, 2017, 6:34 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1495374962 -7200
#      Sun May 21 15:56:02 2017 +0200
# Node ID 6cc1cfd2eaeb90865e03c36cf7e6d7bf8acf9a2a
# Parent  e6ba7dd3a8937b03d58b9952b590e03af456b47b
# EXP-Topic fast-compute-hidden
# Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 6cc1cfd2eaeb
hidden: drop outdated comment about "dynamic" performance

This comment is now irrelevant since we have a faster algorithm and no cache.

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -29,11 +29,8 @@  def hideablerevs(repo):
     return obsolete.getrevs(repo, 'obsolete')
 
 def revealedrevs(repo):
-    """Non-cacheable revisions blocking hidden changesets from being filtered.
-
-    Get revisions that will block hidden changesets and are likely to change,
-    but unlikely to create hidden blockers. They won't be cached, so be careful
-    with adding additional computation."""
+    """non-cacheable revisions blocking hidden changesets from being filtered
+    """
 
     cl = repo.changelog
     blockers = set()