From patchwork Wed May 24 22:26:28 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [STABLE] exchange: print full reason variable
From: Gregory Szorc <gregory.szorc@gmail.com>
X-Patchwork-Id: 20887
Message-Id: <9d6031df42c834b38489.1495664788@ubuntu-vm-main>
To: mercurial-devel@mercurial-scm.org
Date: Wed, 24 May 2017 15:26:28 -0700

# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1495664724 25200
#      Wed May 24 15:25:24 2017 -0700
# Branch stable
# Node ID 9d6031df42c834b38489d798e4b9b9cc7dd17207
# Parent  f928d53b687cb5738528d2eae97f58da10ca8bae
exchange: print full reason variable

This commit essentially reverts 69ac9aebbc55.

urllib2.URLError receives a "reason" argument. It isn't always a
tuple. Mozilla has experienced at least IndexError failures due
to the reason[1] access.
https://bugzilla.mozilla.org/show_bug.cgi?id=1364687

diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -2018,7 +2018,7 @@ def trypullbundlefromurl(ui, repo, url):
             except urlerr.httperror as e:
                 ui.warn(_('HTTP error fetching bundle: %s\n') % str(e))
             except urlerr.urlerror as e:
-                ui.warn(_('error fetching bundle: %s\n') % e.reason[1])
+                ui.warn(_('error fetching bundle: %s\n') % e.reason)
 
             return False
         finally: