Patchwork tests: avoid renamed files triggering check-commit failures

login
register
mail settings
Submitter Augie Fackler
Date May 21, 2017, 12:55 a.m.
Message ID <5db6d70fd30b2f76058a.1495328140@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/20779/
State Accepted
Headers show

Comments

Augie Fackler - May 21, 2017, 12:55 a.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1495327829 14400
#      Sat May 20 20:50:29 2017 -0400
# Node ID 5db6d70fd30b2f76058abfa3c39fae66f9d97812
# Parent  71e735bd8170bccd74f556388b7c4d491f890701
tests: avoid renamed files triggering check-commit failures

I had to flag some revisions to not undergo check-commit scrutiny
today to get the tests to pass, because they renamed files that had
existing failures which we're not cleaning up. Let's prevent that in
the future by using the extended git diff format to elide moved code.
Yuya Nishihara - May 21, 2017, 3:53 a.m.
On Sat, 20 May 2017 20:55:40 -0400, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1495327829 14400
> #      Sat May 20 20:50:29 2017 -0400
> # Node ID 5db6d70fd30b2f76058abfa3c39fae66f9d97812
> # Parent  71e735bd8170bccd74f556388b7c4d491f890701
> tests: avoid renamed files triggering check-commit failures

Thanks for fixing it. Queued.

Patch

diff --git a/tests/test-check-commit.t b/tests/test-check-commit.t
--- a/tests/test-check-commit.t
+++ b/tests/test-check-commit.t
@@ -9,7 +9,7 @@  Go back in the hg repo
   $ cd $TESTDIR/..
 
   $ for node in `hg log --rev 'not public() and ::. and not desc("# no-check-commit")' --template '{node|short}\n'`; do
-  >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out
+  >    hg export --git $node | contrib/check-commit > ${TESTTMP}/check-commit.out
   >    if [ $? -ne 0 ]; then
   >        echo "Revision $node does not comply with rules"
   >        echo '------------------------------------------------------'