Submitter | Jun Wu |
---|---|
Date | May 4, 2017, 1:19 a.m. |
Message ID | <6631c8d7398d3bab3135.1493860776@x1c> |
Download | mbox | patch |
Permalink | /patch/20411/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 473E22C1C3; Wed, 3 May 2017 21:19:56 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pg1KgIFtQeds; Wed, 3 May 2017 21:19:56 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id DB9402C1C8; Wed, 3 May 2017 21:19:54 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 94F932C1EE for <mercurial-devel@mercurial-scm.org>; Wed, 3 May 2017 21:19:53 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HmISRFQn5r0G for <mercurial-devel@mercurial-scm.org>; Wed, 3 May 2017 21:19:53 -0400 (EDT) Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by mercurial-scm.org (Postfix) with ESMTPS id F19BC2C1C8 for <mercurial-devel@mercurial-scm.org>; Wed, 3 May 2017 21:19:52 -0400 (EDT) Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.20/8.16.0.20) with SMTP id v4417TWq029945 for <mercurial-devel@mercurial-scm.org>; Wed, 3 May 2017 18:19:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=content-type : mime-version : content-transfer-encoding : subject : message-id : in-reply-to : references : date : from : to; s=facebook; bh=slUjdt1O09JeV9yqF39x1VSP/558RyUN0HtsXU7OfBw=; b=pZKIta2Sm0nCxcsfw9oLSn4wFCbKcl9kC93kIUjJWBdUaNO0zlwxeicYuICaRKj35Zx3 o/p2cvqgXV5aUmhD8tE8++2nBwkBbJD4Pa5RSoNLRlw+YlS5RHf/TZiXfBmBEfSGmX/O CqA6c1fNzQ3l1l86mcvblgChIeTzUBfqhgA= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 2a7pyygtpy-2 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for <mercurial-devel@mercurial-scm.org>; Wed, 03 May 2017 18:19:52 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 3 May 2017 18:19:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=slUjdt1O09JeV9yqF39x1VSP/558RyUN0HtsXU7OfBw=; b=efjZOkzkB0TdNfIMyHdS+ZS//qzlLkew5TttwrcHhNmKviQ8eVm8O2QoEWiILdwo8wntEq09sfm4Hh6M2pSvd3xDDqAV1HUvrZ1dEAyeqQglnfyIpDnXs6yVJvOPSPokgUFsYBzyM/fc/9QCtcBLHhmaArGCk9FtO8MTICALSgw= Authentication-Results: mercurial-scm.org; dkim=none (message not signed) header.d=none; mercurial-scm.org; dmarc=none action=none header.from=fb.com; Received: from [127.0.0.1] (199.201.64.4) by DM5PR15MB1514.namprd15.prod.outlook.com (10.173.225.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 4 May 2017 01:19:48 +0000 MIME-Version: 1.0 Subject: [PATCH 3 of 3] webcommands: use fctx.isbinary X-Mercurial-Node: 6631c8d7398d3bab3135b116ad9fe5072804a501 X-Mercurial-Series-Index: 3 X-Mercurial-Series-Total: 3 Message-ID: <6631c8d7398d3bab3135.1493860776@x1c> X-Mercurial-Series-Id: <7bfa6bc376e3dd504276.1493860774@x1c> In-Reply-To: <7bfa6bc376e3dd504276.1493860774@x1c> References: <7bfa6bc376e3dd504276.1493860774@x1c> User-Agent: Mercurial-patchbomb/4.2+13-7d3535d27798 Date: Wed, 3 May 2017 18:19:36 -0700 From: Jun Wu <quark@fb.com> To: <mercurial-devel@mercurial-scm.org> X-Originating-IP: [199.201.64.4] X-ClientProxiedBy: CO2PR07CA0073.namprd07.prod.outlook.com (10.174.192.41) To DM5PR15MB1514.namprd15.prod.outlook.com (10.173.225.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a31c25da-bf49-46b0-741a-08d4928ba827 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM5PR15MB1514; X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1514; 3:tThhkS8WqQEDl3aQErpw+TB2jibq0xXMaN+w+zoqS1CyQBaEU3OlQesoleaT6KjVqqYS324GAxzrt15vxKWvQh57JB31VGY+gP8pEujfIdz9Vs9xpIUvqS8jXiC9iM7vWmIuQtM1Cg1kURTzo8i6URYZtDu4az+BCFhgfdr/jcENiCOzuUGUwOpvAIskXbIzTJDLE4pUs+H3Piq0X09T5MDFLSlu0M9t38VJsnlRPczGyhRDFaNGWF9/rCtQjjOmgJVlF2T5ZxKVBqKulppaELnqBfjGNrVIi3VuIEiQmUQ5iuEhi/qB2OtG8zoZZH8pEeWJVLe8ubQkzbXeKImwgg==; 25:iQr46tcwMyErK0qEPc3Be+rxBNqPX+IRXqNRcn55e7SPlpl8N1Hi9Iy46P48mTYAjxo++eWgKblJpW/VP+gFzh5q9N1MxlL/B/fjbI7cXUollYglYh3S5Ed3diqhZSRF7QYw27emHtM2frRX3Fi4l+GpOqX1xkGNowRey2fK2Xyx6QJ2sGbqsN/3nZzJ16moIz26JMazeyyTvfJXM19uAbF7vnCAJeAOxpCeO4hTzG6Oh0auS2OuzYO3n3YgY6H6QcoXMtsGcRFghEriv2zBplNAIG9ZwQZq3pVoNFtf5+MTNOUHAxZMmqkN34ULqxe1eHutE7JdLyZfJMysnEWbBOtGP/VmX+zMATmrPCCthtQuCxrkKu3SNkucBamRfHB7iVK2DVGSpR7hfLW0zIJRW6rEG9iGpq/a8m0dLFNnef4FF+qMXCPhVs8f4Q0pO0tjoNFkUbvxffItf+IUYhQkKw== X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1514; 31:dvOyCwCTr9osT/Qysinqmi2gN3dJEuxl918rEtvMFF6+l6rjCZepoxIBcNyTuVTI1XvmuZ6exkM1KPn019JttaVLyM/0UnD6cqd1zJePeGeE+TXCcD6qPokLqrNbiowbUTQXTwrE+LYnUhQ5WRCT2IDAAGkIo8+z6I3tV6WHz9ISRVd6Nyqhnyf5iU9MNox9yXgl+8y8muQuPauIYEF85rDB/5Sg4gkUxSwK8FDtL5HFv+Q8kzpLgnfVV8YL5jMsIExivUy92wn/G0v4fJ9R44ajYllidxDLeyMagXnoOnI=; 20:cc4pgYYMap8b+CVkjHLCyrMfKkrOp67lBqZRvqHIJot5RcVBeRBhN15tRYHQdcYQ9/UpwnFsS8eeoxVzxjU8ejMYyYC3TLEocyCcz95skMi0JX4dlE3m+Y3XhbPkyqqOmODT+oiOC4DkjSlEHSeE2RMTqZffcfntrm6BKrDFiYEk1OuuljVmjHQd4IZILrkz8mmY5DatdHv6lJ5ZmS60rL5EDJ3KhmnuleNg+Iq5oZAKxif1pFoLgCsa++JFQDK1/CfbhACl+SCxkk3sRe6s3HpeZiaBDkTjg7lC1po03RPgbIlsmghE2Wk8Rhzet/o56D3gcKvqKNTOUT0kcMz3KLLktF7mpiyZyndPSjSuHeaqoCI7is5zRIgH9pVXcqRT9vacUiyaHfYC+XOZBEAQFRyjwS0y1ISb5VSU1ZLizWRxN5zEqw0mc7bn5NQ3gYo+ZQRBJcdFLYBOlrbKROOvxmH8IDYGMHBl553xdfZeWucN6aAAOHHOMN93AwIPO0/p X-Microsoft-Antispam-PRVS: <DM5PR15MB1514DAEBFC5BA80A7C67B506CDEA0@DM5PR15MB1514.namprd15.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(63843785518722); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(6072148); SRVR:DM5PR15MB1514; BCL:0; PCL:0; RULEID:; SRVR:DM5PR15MB1514; X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1514; 4:r4DSxVBfx6DPAnEsWnYcF0Q2Pifd859OEAAzCEAzVSxoWbX/kISIEAFuom/CFbloHPsAbiX0dvSDCCJHQ2xkqIM5V+LxkG7NCCR9B4kuYktF23KIqcwWFdw5dmG+4i6OY2Urw6lFnTMSiTlwqGsQhWcnr1TOoFUlzlQE8UlFT6eoA3Y71GbW2TfEPgL6t2W6DBlNEj2OZq+wYwUfcAukiDx0rU7jg2V8g2LYlBDlwKtXmUluPycVgOpXR2JTuWehYpxpeQE1cil6o0AAdTxZTVcuujz24DtGLRnf+RrBlvxMwIUhz4aqc7daPK2tvIfT9+MG6d+INj0eIiwhD3ZgTPN2YzrVC95WU3CDXyiWV6ocpMTFuv0+xxb4cfPT89bq2Po86+u8bDWhRmU1mQ7Gd3stS2FT2mpKreUttFnyzBC4aAnexEErDSmD0qmBH8xGheH3SfmZWwTio5aYLTyvTW7xDAnUK/XPpn/Bga9SASPLz3XJp8qQw6+fy1FJxzood1vL97M7MHrmsqTbAjlRDJlyFKZgUEV+kfymtw6AbUmIfonqtnKBHBOCyQnLaiNOjfiNQJQU8qVXeaA3/2oMhGDGfV/eiO6ZAv46hWuwpt4rvkaRamq5FOD3fdoA54sWS22ZVJ7vjlhcyUQeb+mE/w++2WcxCUfr80b/LQS6O5p6nUf7ur7BUoHcfV4qv72l2VPWZCUfMu6+b8UbihqnO+H9q7iMoqdbD9CbhInow4ZE7RHgPZYeCIrvqGG/oE9j+eKHSI4qgD8UYyHqv31Z44N2XVSRb6O8iwdVELN5yJSNsf2vz17wjJtVvOaIWYjR6ft5k66lJUxAY8Ks9I/a/cODpRLXZU4EqeLDxZHx0Ig= X-Forefront-PRVS: 02973C87BC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39410400002)(39850400002)(39840400002)(39450400003)(38730400002)(23726003)(33646002)(2351001)(25786009)(8676002)(6666003)(46406003)(3846002)(42186005)(6116002)(6916009)(110136004)(33716001)(2950100002)(53936002)(50986999)(97756001)(4001350100001)(77096006)(6306002)(86362001)(90366009)(9686003)(305945005)(81166006)(6486002)(47776003)(50466002)(66066001)(83506001)(575784001)(7736002)(478600001)(2906002)(230700001)(54356999)(5660300001)(189998001)(76176999); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR15MB1514; H:[127.0.0.1]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR15MB1514; 23:N6vMOSWDPzaUIf3hjOd1vMFjy4FC9uKULfo4/W0rY?= =?us-ascii?Q?KAPvmfTO7H7WnGzO1q5AeNaR65KKGh/5BhzvvHIUHFciCmpfpPrKY6r0EvJf?= =?us-ascii?Q?z92GUbqUZopveTv1G3WQas74Z881MMlBLzxsasQX8722A20oeGsIv/sXLRlp?= =?us-ascii?Q?EY8c/tsPTTszAtWKKjWtSaRDePN4UjbpTnn+9Q4h3GDCCwZbHY0C7gipZeLi?= =?us-ascii?Q?yXRoomJjeBlOuYfxG88+aqulr+zFy1E2CjWHHVRvbaqsaT4IMzR6ZDCumg9o?= =?us-ascii?Q?8POSeD91ckCDV2Tt1bfRwbWQQC6Ol27aLgBaC/UJROqQ5M3MYgo/9yGpSG/n?= =?us-ascii?Q?VroVETUscdM58oOEcrzG6ngxMkm6nWdY8KZQ8dZJTOjSp6b8GF1GtHOiTKgd?= =?us-ascii?Q?51pyFJ3vYLyYH7MARViefnLfuAax/DnPR2YaAhmgyN6i9QbRFNmPfYEmtPEW?= =?us-ascii?Q?wdsyeJ2fNqY4P4gKn29XjoAtq6hksSDo3nn2rsHcxw+KLxQldG/HoupLio/X?= =?us-ascii?Q?1OA13utqcOEpNGJrNDSnjInE1LE+ksBfGl6c+WRU/YdMJ5nRK4XVBy7N1ipn?= =?us-ascii?Q?bRFd7Blg2EgZxoq3d6TYw/BH/uFhV4Z603R89iid5jeThuSNQ0mhEYRAgJ/d?= =?us-ascii?Q?qKrwdEbKmaU0iIEgv36nZBcE8jUuOkRSdIpyyp5KKirLz6rE8HVmgyu+FLPC?= =?us-ascii?Q?KzcBlL8rWui4S4w57k8pZOvWpXX2Vo8UsBXIQqi68qi5tUOj9xOddqPokJKO?= =?us-ascii?Q?P3iaFI2RkVf/WL8AcKFZakpBoEZKpsKJ5B7xCJ4dr65BC9agKIQ7DTB5UcuT?= =?us-ascii?Q?LMpYg8MgP0k4hrEadqGMq+TDy2Gj2TQjB3/jCDK6W2hA+igwsESXKi4QQURM?= =?us-ascii?Q?PlLxKoXX5Etchu8lDg8gAVE2Rp2Barjnuqcn7lTCDhmxkf8zLUcOSo4nRrU6?= =?us-ascii?Q?4do3Se+rljyjyjUWogj5zfMPoY6QPnjnz54Sy9J63ZEs2rC1xnGCpUamriuJ?= =?us-ascii?Q?YAUpqjBaQGXu3SLpIJ9lqwQw98yPYJGD4izwTnEh2L5C3W2dR1olj1Yx+U6P?= =?us-ascii?Q?x47OZL+26BRlqIIFI6stgRR+4wZ3iBMyemtS+5uAYdUaxfL72Wd3tf4YfmYS?= =?us-ascii?Q?a+j7MHEFhA/QUl+BGZQrGOeJl2o3/l4ruObCpsZ8PSu0/nFo0MkPwV0uPASq?= =?us-ascii?Q?SbRs7ddE+kz6WQOFhu721eoCfF8s3GounMU?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1514; 6:s2NUMQuID4pHY9kS+sBU5FObarfSwVExIPfmVwWYSzdm+I+37GqOe9s/uh+yMYUqvQoAAbSBH/mJAdMFrry3MX9Mokf60dUvxjhEBykflZpjDmYkqTesbbLoM2MkTJKEiGrqk0jy98VaoXr9HYcfXHGP3JyHkBeI/3sxTSf3E/RAuZuHhJ9byuZ/9C7ynSEjK9a6I0D91hffGLdLpOww2BFgODoLS6wfWFvOtl2XLURxubPI2eLtf+L0Tpg+H2ta2MuUZ0nvAuFGMjeAqJ3wMCU53nJPDzRe/sPy31MUyv4UQe0HaMW1GPQ5McEFsNc7hgktocwRSstKvBOo0aNjauobq/HKiJ7VXpP8AR5D2OX+t4DI+Yxmt+LVK4o3p6bQW8MZ8Wu7NAADWlyivk6bBLx/3Dom8CjL2pvh25gTmUB1akI9bSelHDlJp0AiE3gDiHkZkmHGChXhipLxmVj2cuh3/5TV9M8DPrVwNziXh0j483iGdAlPI43Mne9ysioHRyOaU3vmNx6HNLEJAiQL0w==; 5:yWEqDC0XC//CIvbhXm07offHuiPm7JAneOWk9MX9DzK0h29azXOlgTGva9ma5J+0QTSTpS3k/caPU4Aa4trG9IXJZTfagV4KY2I7FAkbST0J0/VEKrsxu3N76OdNbzYe6PWo03Bcv89uGB44RU9rXQ==; 24:Min+I71zene6jQs5RaCzN+C0WD7C7nMynsyQDpHu65lK/AjlWVmQN5SuzLM5kdYYiuzAs8NdOvQjI0jz743fsPn+pCyApQKJrLaW9zjF2SI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1514; 7:YSBGJf5igHg4ibAf7J6RVgl4cc0UL0A+4Ki6CY/htwBQFkG+DsMbEoBsW1owgqrUcKpseeMJcPPz/0GJ8VO1esmGeSz4OYCGIdmf/5ajGxSJ00lFIZha2S98Nm6mk1YlrvV+YORu3G/gnTu8NP8l+CCKWqX72YZ36QuzBs1Bw8rd+kN+j5phR/4AepHAJ2rgKTfDFCMBq1MQsM5XX7H1dmHFOFhHMFMoprfQlerlPQajJX4+SD1JmketNFBqBi/LIRpXObSPCr1e/CGqQq3luhHginLP58crPR6+k0tyzGL6sGTAFPnV7ZNa8z326Xw5kJDKUxp389FKIe5k2bOOpw==; 20:ARy8iPrPVzKdyJnpRpi3yL0+VEQctQnTH1J7boLFCWiMHdWbvvg9ePbLrPjZyTly8YlKHDN57faUwzHYGZHF4KMzBxRKBMbnF6p5JxTQM7/GGa28Vl9qtSWMvb62x7Z+CkSvERiJKVUotapgg8CDJtVDSreUR7Q6GFDWuTv/Flk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 01:19:48.2377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1514 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-03_18:, , signatures=0 X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Jun Wu - May 4, 2017, 1:19 a.m.
Patch
diff --git a/mercurial/hgweb/webcommands.py b/mercurial/hgweb/webcommands.py --- a/mercurial/hgweb/webcommands.py +++ b/mercurial/hgweb/webcommands.py @@ -809,5 +809,5 @@ def comparison(web, req, tmpl): def filelines(f): - if util.binary(f.data()): + if f.isbinary(): mt = mimetypes.guess_type(f.path())[0] if not mt: @@ -887,5 +887,5 @@ def annotate(web, req, tmpl): def annotate(**map): - if util.binary(fctx.data()): + if fctx.isbinary(): mt = (mimetypes.guess_type(fctx.path())[0] or 'application/octet-stream')