Patchwork internals: document that "branches" is a legacy command

login
register
mail settings
Submitter Siddharth Agarwal
Date May 3, 2017, 9:07 p.m.
Message ID <7e90b9553a02ef30fd28.1493845659@devvm028.frc2.facebook.com>
Download mbox | patch
Permalink /patch/20410/
State Accepted
Headers show

Comments

Siddharth Agarwal - May 3, 2017, 9:07 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1493845634 25200
#      Wed May 03 14:07:14 2017 -0700
# Node ID 7e90b9553a02ef30fd289736cfb559c83b6766e2
# Parent  8ac7ac714e922fd34abe9f5a16fcf018c8b12abc
internals: document that "branches" is a legacy command

Modern clients use a different discovery mechanism.
Siddharth Agarwal - May 3, 2017, 9:13 p.m.
On 5/3/17 22:07, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0@fb.com>
> # Date 1493845634 25200
> #      Wed May 03 14:07:14 2017 -0700
> # Node ID 7e90b9553a02ef30fd289736cfb559c83b6766e2
> # Parent  8ac7ac714e922fd34abe9f5a16fcf018c8b12abc
> internals: document that "branches" is a legacy command

As martinvonz helpfully pointed out on IRC, this should read "legacy 
wire command". Whoops!


>
> Modern clients use a different discovery mechanism.
>
> diff --git a/mercurial/help/internals/wireprotocol.txt b/mercurial/help/internals/wireprotocol.txt
> --- a/mercurial/help/internals/wireprotocol.txt
> +++ b/mercurial/help/internals/wireprotocol.txt
> @@ -632,6 +632,9 @@ There is no trailing newline.
>   branches
>   --------
>   
> +(Legacy command used for discovery in old clients. Clients with ``getbundle``
> +use the ``known`` and ``heads`` commands instead.)
> +
>   Obtain ancestor changesets of specific nodes back to a branch point.
>   
>   Despite the name, this command has nothing to do with Mercurial named branches.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Yuya Nishihara - May 4, 2017, 3:54 a.m.
On Wed, 3 May 2017 22:13:17 +0100, Siddharth Agarwal wrote:
> On 5/3/17 22:07, Siddharth Agarwal wrote:
> > # HG changeset patch
> > # User Siddharth Agarwal <sid0@fb.com>
> > # Date 1493845634 25200
> > #      Wed May 03 14:07:14 2017 -0700
> > # Node ID 7e90b9553a02ef30fd289736cfb559c83b6766e2
> > # Parent  8ac7ac714e922fd34abe9f5a16fcf018c8b12abc
> > internals: document that "branches" is a legacy command
> 
> As martinvonz helpfully pointed out on IRC, this should read "legacy 
> wire command". Whoops!

Updated the commit summary and queued, thanks.

Patch

diff --git a/mercurial/help/internals/wireprotocol.txt b/mercurial/help/internals/wireprotocol.txt
--- a/mercurial/help/internals/wireprotocol.txt
+++ b/mercurial/help/internals/wireprotocol.txt
@@ -632,6 +632,9 @@  There is no trailing newline.
 branches
 --------
 
+(Legacy command used for discovery in old clients. Clients with ``getbundle``
+use the ``known`` and ``heads`` commands instead.)
+
 Obtain ancestor changesets of specific nodes back to a branch point.
 
 Despite the name, this command has nothing to do with Mercurial named branches.