Patchwork [2,of,2,STABLE] hgweb: change text of followlines links to "older / newer"

login
register
mail settings
Submitter Denis Laxalde
Date April 24, 2017, 11:37 a.m.
Message ID <3ce5bd43168bfebfe854.1493033854@sh77.tls.logilab.fr>
Download mbox | patch
Permalink /patch/20283/
State Accepted
Headers show

Comments

Denis Laxalde - April 24, 2017, 11:37 a.m.
# HG changeset patch
# User Denis Laxalde <denis.laxalde@logilab.fr>
# Date 1493023687 -7200
#      Mon Apr 24 10:48:07 2017 +0200
# Branch stable
# Node ID 3ce5bd43168bfebfe854ee944cc8f6936c0a683b
# Parent  713eaf91eb7e80d954de1b3a8b3963e5367e1a9b
# Available At http://hg.logilab.org/users/dlaxalde/hg
#              hg pull http://hg.logilab.org/users/dlaxalde/hg -r 3ce5bd43168b
hgweb: change text of followlines links to "older / newer"

DAG directions "descending" / "ascending" arguably do not make much sense in
the web interface where changes are usually listed by "dates".
Sean Farley - April 24, 2017, 4:56 p.m.
Denis Laxalde <denis@laxalde.org> writes:

> # HG changeset patch
> # User Denis Laxalde <denis.laxalde@logilab.fr>
> # Date 1493023687 -7200
> #      Mon Apr 24 10:48:07 2017 +0200
> # Branch stable
> # Node ID 3ce5bd43168bfebfe854ee944cc8f6936c0a683b
> # Parent  713eaf91eb7e80d954de1b3a8b3963e5367e1a9b
> # Available At http://hg.logilab.org/users/dlaxalde/hg
> #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r 3ce5bd43168b
> hgweb: change text of followlines links to "older / newer"
>
> DAG directions "descending" / "ascending" arguably do not make much sense in
> the web interface where changes are usually listed by "dates".

Hmmm, I guess so. I'm not sure I have a better suggestion. Parent /
child might be confusing as well since these are filelogs.
Gregory Szorc - April 24, 2017, 6:04 p.m.
On Mon, Apr 24, 2017 at 9:56 AM, Sean Farley <sean@farley.io> wrote:

> Denis Laxalde <denis@laxalde.org> writes:
>
> > # HG changeset patch
> > # User Denis Laxalde <denis.laxalde@logilab.fr>
> > # Date 1493023687 -7200
> > #      Mon Apr 24 10:48:07 2017 +0200
> > # Branch stable
> > # Node ID 3ce5bd43168bfebfe854ee944cc8f6936c0a683b
> > # Parent  713eaf91eb7e80d954de1b3a8b3963e5367e1a9b
> > # Available At http://hg.logilab.org/users/dlaxalde/hg
> > #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r
> 3ce5bd43168b
> > hgweb: change text of followlines links to "older / newer"
> >
> > DAG directions "descending" / "ascending" arguably do not make much
> sense in
> > the web interface where changes are usually listed by "dates".
>
> Hmmm, I guess so. I'm not sure I have a better suggestion. Parent /
> child might be confusing as well since these are filelogs.
>

I suggested the new terminology. Since this view is for files and is
somewhat distanced from the DAG, I didn't think terminology associated with
the DAG made sense and could even be confusing.
Sean Farley - April 24, 2017, 6:10 p.m.
Gregory Szorc <gregory.szorc@gmail.com> writes:

> On Mon, Apr 24, 2017 at 9:56 AM, Sean Farley <sean@farley.io> wrote:
>
>> Denis Laxalde <denis@laxalde.org> writes:
>>
>> > # HG changeset patch
>> > # User Denis Laxalde <denis.laxalde@logilab.fr>
>> > # Date 1493023687 -7200
>> > #      Mon Apr 24 10:48:07 2017 +0200
>> > # Branch stable
>> > # Node ID 3ce5bd43168bfebfe854ee944cc8f6936c0a683b
>> > # Parent  713eaf91eb7e80d954de1b3a8b3963e5367e1a9b
>> > # Available At http://hg.logilab.org/users/dlaxalde/hg
>> > #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r
>> 3ce5bd43168b
>> > hgweb: change text of followlines links to "older / newer"
>> >
>> > DAG directions "descending" / "ascending" arguably do not make much
>> sense in
>> > the web interface where changes are usually listed by "dates".
>>
>> Hmmm, I guess so. I'm not sure I have a better suggestion. Parent /
>> child might be confusing as well since these are filelogs.
>>
>
> I suggested the new terminology. Since this view is for files and is
> somewhat distanced from the DAG, I didn't think terminology associated with
> the DAG made sense and could even be confusing.

Makes sense. And it's not a terrible name either :-)
Yuya Nishihara - April 25, 2017, 2:35 p.m.
On Mon, 24 Apr 2017 11:10:52 -0700, Sean Farley wrote:
> Gregory Szorc <gregory.szorc@gmail.com> writes:
> 
> > On Mon, Apr 24, 2017 at 9:56 AM, Sean Farley <sean@farley.io> wrote:
> >
> >> Denis Laxalde <denis@laxalde.org> writes:
> >>
> >> > # HG changeset patch
> >> > # User Denis Laxalde <denis.laxalde@logilab.fr>
> >> > # Date 1493023687 -7200
> >> > #      Mon Apr 24 10:48:07 2017 +0200
> >> > # Branch stable
> >> > # Node ID 3ce5bd43168bfebfe854ee944cc8f6936c0a683b
> >> > # Parent  713eaf91eb7e80d954de1b3a8b3963e5367e1a9b
> >> > # Available At http://hg.logilab.org/users/dlaxalde/hg
> >> > #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r
> >> 3ce5bd43168b
> >> > hgweb: change text of followlines links to "older / newer"
> >> >
> >> > DAG directions "descending" / "ascending" arguably do not make much
> >> sense in
> >> > the web interface where changes are usually listed by "dates".
> >>
> >> Hmmm, I guess so. I'm not sure I have a better suggestion. Parent /
> >> child might be confusing as well since these are filelogs.
> >>
> >
> > I suggested the new terminology. Since this view is for files and is
> > somewhat distanced from the DAG, I didn't think terminology associated with
> > the DAG made sense and could even be confusing.
> 
> Makes sense. And it's not a terrible name either :-)

Seems fine. Queued per reviews, thanks.

Patch

diff --git a/mercurial/templates/static/followlines.js b/mercurial/templates/static/followlines.js
--- a/mercurial/templates/static/followlines.js
+++ b/mercurial/templates/static/followlines.js
@@ -213,7 +213,7 @@  document.addEventListener('DOMContentLoa
         var aAsc = document.createElement('a');
         var url = targetUri + '?patch=&linerange=' + fromline + ':' + toline;
         aAsc.setAttribute('href', url);
-        aAsc.textContent = 'ascending';
+        aAsc.textContent = 'older';
         aDiv.appendChild(aAsc);
 
         if (!isHead) {
@@ -222,7 +222,7 @@  document.addEventListener('DOMContentLoa
             //     link to "descending" followlines
             var aDesc = document.createElement('a');
             aDesc.setAttribute('href', url + '&descend=');
-            aDesc.textContent = 'descending';
+            aDesc.textContent = 'newer';
             aDiv.appendChild(aDesc);
         }