Patchwork [1,of,3] test-tag: make hook runnable on Windows

login
register
mail settings
Submitter Matt Harbison
Date April 17, 2017, 1:35 a.m.
Message ID <85faa957af5a8aad904f.1492392958@Envy>
Download mbox | patch
Permalink /patch/20243/
State Accepted
Headers show

Comments

Matt Harbison - April 17, 2017, 1:35 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1492390754 14400
#      Sun Apr 16 20:59:14 2017 -0400
# Node ID 85faa957af5a8aad904fdadaf38e1b0de366ed2c
# Parent  25146c0366d4f497be856a35c078ede207bbee87
test-tag: make hook runnable on Windows

Simply setting the hook to *.sh causes Windows to open a dialog asking how to
open *.sh files.
Yuya Nishihara - April 17, 2017, 1:29 p.m.
On Sun, 16 Apr 2017 21:35:58 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1492390754 14400
> #      Sun Apr 16 20:59:14 2017 -0400
> # Node ID 85faa957af5a8aad904fdadaf38e1b0de366ed2c
> # Parent  25146c0366d4f497be856a35c078ede207bbee87
> test-tag: make hook runnable on Windows

Looks good. Queued, thanks.

Patch

diff --git a/tests/test-tag.t b/tests/test-tag.t
--- a/tests/test-tag.t
+++ b/tests/test-tag.t
@@ -2,7 +2,7 @@ 
   > [experimental]
   > hook-track-tags=1
   > [hooks]
-  > txnclose.track-tag=${TESTTMP}/taghook.sh
+  > txnclose.track-tag=sh ${TESTTMP}/taghook.sh
   > EOF
 
   $ cat << EOF > taghook.sh
@@ -14,7 +14,6 @@ 
   >     sed 's/^/hook: /' .hg/changes/tags.changes
   > fi
   > EOF
-  $ chmod +x taghook.sh
   $ hg init test
   $ cd test