Patchwork [3,of,3] color: also enable by default on windowso

login
register
mail settings
Submitter Pierre-Yves David
Date April 16, 2017, 12:55 a.m.
Message ID <9d4f7de0a25c91103f64.1492304127@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/20236/
State Accepted
Headers show

Comments

Pierre-Yves David - April 16, 2017, 12:55 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1492302848 -7200
#      Sun Apr 16 02:34:08 2017 +0200
# Node ID 9d4f7de0a25c91103f6419c4675bcb21ad7c5098
# Parent  7ec1415a4de91a5c56e549cd4a40cb8e9411f8d9
# EXP-Topic color
# Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 9d4f7de0a25c
color: also enable by default on windowso

I've not found anything related to color + windows on the bug tracker. So I'm
suggesting we get bolder and turn it on for windows too in the release
candidate. We can always backout that changeset if we find serious issue on
windows.
Josef 'Jeff' Sipek - April 18, 2017, 2:19 a.m.
On Sun, Apr 16, 2017 at 02:55:27 +0200, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1492302848 -7200
> #      Sun Apr 16 02:34:08 2017 +0200
> # Node ID 9d4f7de0a25c91103f6419c4675bcb21ad7c5098
> # Parent  7ec1415a4de91a5c56e549cd4a40cb8e9411f8d9
> # EXP-Topic color
> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 9d4f7de0a25c
> color: also enable by default on windowso

Typo in "windows".

Jeff.

> 
> I've not found anything related to color + windows on the bug tracker. So I'm
> suggesting we get bolder and turn it on for windows too in the release
> candidate. We can always backout that changeset if we find serious issue on
> windows.
> 
> diff --git a/mercurial/color.py b/mercurial/color.py
> --- a/mercurial/color.py
> +++ b/mercurial/color.py
> @@ -45,7 +45,7 @@ except ImportError:
>      curses = None
>      _baseterminfoparams = {}
>  
> -_enabledbydefault = pycompat.osname != 'nt'
> +_enabledbydefault = True
>  
>  # start and stop parameters for effects
>  _effects = {
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Yuya Nishihara - April 18, 2017, 11:13 a.m.
On Mon, 17 Apr 2017 22:19:37 -0400, Josef 'Jeff' Sipek wrote:
> On Sun, Apr 16, 2017 at 02:55:27 +0200, Pierre-Yves David wrote:
> > # HG changeset patch
> > # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> > # Date 1492302848 -7200
> > #      Sun Apr 16 02:34:08 2017 +0200
> > # Node ID 9d4f7de0a25c91103f6419c4675bcb21ad7c5098
> > # Parent  7ec1415a4de91a5c56e549cd4a40cb8e9411f8d9
> > # EXP-Topic color
> > # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> > #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 9d4f7de0a25c
> > color: also enable by default on windowso
> 
> Typo in "windows".

Doh, fixed in flight.

Patch

diff --git a/mercurial/color.py b/mercurial/color.py
--- a/mercurial/color.py
+++ b/mercurial/color.py
@@ -45,7 +45,7 @@  except ImportError:
     curses = None
     _baseterminfoparams = {}
 
-_enabledbydefault = pycompat.osname != 'nt'
+_enabledbydefault = True
 
 # start and stop parameters for effects
 _effects = {