Patchwork [V2] test-patchbomb: disable sendmail tests on Windows

login
register
mail settings
Submitter Matt Harbison
Date April 11, 2017, 1:19 a.m.
Message ID <bfa323bbeebb534f3540.1491873571@Envy>
Download mbox | patch
Permalink /patch/20101/
State Accepted
Headers show

Comments

Matt Harbison - April 11, 2017, 1:19 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1491873174 14400
#      Mon Apr 10 21:12:54 2017 -0400
# Node ID bfa323bbeebb534f3540e9198648f1bd317b059a
# Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0
test-patchbomb: disable sendmail tests on Windows

These tests were failing, and there isn't a trivial way to execute a script on
Windows [1].

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096497.html
Kostia Balytskyi - April 11, 2017, 9:46 a.m.
This looks good to me. Yay for Windows work.

> -----Original Message-----

> From: Mercurial-devel [mailto:mercurial-devel-bounces@mercurial-scm.org]

> On Behalf Of Matt Harbison

> Sent: Tuesday, 11 April, 2017 02:20

> To: mercurial-devel@mercurial-scm.org

> Subject: [PATCH V2] test-patchbomb: disable sendmail tests on Windows

> 

> # HG changeset patch

> # User Matt Harbison <matt_harbison@yahoo.com> # Date 1491873174

> 14400

> #      Mon Apr 10 21:12:54 2017 -0400

> # Node ID bfa323bbeebb534f3540e9198648f1bd317b059a

> # Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0

> test-patchbomb: disable sendmail tests on Windows

> 

> These tests were failing, and there isn't a trivial way to execute a script on

> Windows [1].

> 

> [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-

> 2Dscm.org_pipermail_mercurial-2Ddevel_2017-

> 2DApril_096497.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Pp-

> gQYFgs4tKlSFPF5kfCw&m=MoB7XlhA2TGKLQ2ITzZ14aL8bHY2vW_bl_phlFSKn

> HU&s=HGhzSkDpZvQt5Ip1fSXI5vCi3wnybW2CX3jisv7G4OI&e=

> 

> diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t

> --- a/tests/test-patchbomb.t

> +++ b/tests/test-patchbomb.t

> @@ -2846,6 +2846,7 @@

>    @@ -0,0 +1,1 @@

>    +d

> 

> +#if no-windows

> 

>  Set up a fake sendmail program

> 

> @@ -3026,3 +3027,4 @@

>    (use 'hg push $TESTTMP/t3 -r ff2c9fa2018b -r 3b6f1ec9dde9')

>    [255]

> 

> +#endif

> _______________________________________________

> Mercurial-devel mailing list

> Mercurial-devel@mercurial-scm.org

> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-

> 2Dscm.org_mailman_listinfo_mercurial-

> 2Ddevel&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Pp-

> gQYFgs4tKlSFPF5kfCw&m=MoB7XlhA2TGKLQ2ITzZ14aL8bHY2vW_bl_phlFSKn

> HU&s=yxaXSItbhL9M5WeGZ740IOVf-kW0ixZ0F1OK9rJwRS0&e=
Yuya Nishihara - April 11, 2017, 1:06 p.m.
On Tue, 11 Apr 2017 09:46:18 +0000, Kostia Balytskyi wrote:
> This looks good to me. Yay for Windows work.
> 
> > -----Original Message-----
> > From: Mercurial-devel [mailto:mercurial-devel-bounces@mercurial-scm.org]
> > On Behalf Of Matt Harbison
> > Sent: Tuesday, 11 April, 2017 02:20
> > To: mercurial-devel@mercurial-scm.org
> > Subject: [PATCH V2] test-patchbomb: disable sendmail tests on Windows
> > 
> > # HG changeset patch
> > # User Matt Harbison <matt_harbison@yahoo.com> # Date 1491873174
> > 14400
> > #      Mon Apr 10 21:12:54 2017 -0400
> > # Node ID bfa323bbeebb534f3540e9198648f1bd317b059a
> > # Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0
> > test-patchbomb: disable sendmail tests on Windows

Queued, thanks.

Patch

diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t
--- a/tests/test-patchbomb.t
+++ b/tests/test-patchbomb.t
@@ -2846,6 +2846,7 @@ 
   @@ -0,0 +1,1 @@
   +d
   
+#if no-windows
 
 Set up a fake sendmail program
 
@@ -3026,3 +3027,4 @@ 
   (use 'hg push $TESTTMP/t3 -r ff2c9fa2018b -r 3b6f1ec9dde9')
   [255]
 
+#endif