Patchwork test-check-pylint: match its output

login
register
mail settings
Submitter Jun Wu
Date April 7, 2017, 6:10 p.m.
Message ID <58c9ffb81e676df4613c.1491588611@x1c>
Download mbox | patch
Permalink /patch/20004/
State Accepted
Headers show

Comments

Jun Wu - April 7, 2017, 6:10 p.m.
# HG changeset patch
# User Jun Wu <quark@fb.com>
# Date 1491588594 25200
#      Fri Apr 07 11:09:54 2017 -0700
# Node ID 58c9ffb81e676df4613c86c9ebd75836f1567ced
# Parent  0d57661098e3f93e7d1ab4e206d87d39c6ce4f84
# Available At https://bitbucket.org/quark-zju/hg-draft
#              hg pull https://bitbucket.org/quark-zju/hg-draft -r 58c9ffb81e67
test-check-pylint: match its output

"pylint --version" shows:

  pylint 2.0.0,
  astroid 1.5.0
  Python 2.7.13 (default, Dec 21 2016, 07:16:46)
  [GCC 6.2.1 20160830]

I got "Your code has been rated at 10.00/10" every time and didn't know how
to turn it off. Therefore the fix.
Yuya Nishihara - April 8, 2017, 7:32 a.m.
On Fri, 7 Apr 2017 11:10:11 -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark@fb.com>
> # Date 1491588594 25200
> #      Fri Apr 07 11:09:54 2017 -0700
> # Node ID 58c9ffb81e676df4613c86c9ebd75836f1567ced
> # Parent  0d57661098e3f93e7d1ab4e206d87d39c6ce4f84
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 58c9ffb81e67
> test-check-pylint: match its output
> 
> "pylint --version" shows:
> 
>   pylint 2.0.0,
>   astroid 1.5.0
>   Python 2.7.13 (default, Dec 21 2016, 07:16:46)
>   [GCC 6.2.1 20160830]
> 
> I got "Your code has been rated at 10.00/10" every time and didn't know how
> to turn it off. Therefore the fix.

Queued, thanks.
Pierre-Yves David - April 8, 2017, 9:55 a.m.
On 04/08/2017 09:32 AM, Yuya Nishihara wrote:
> On Fri, 7 Apr 2017 11:10:11 -0700, Jun Wu wrote:
>> # HG changeset patch
>> # User Jun Wu <quark@fb.com>
>> # Date 1491588594 25200
>> #      Fri Apr 07 11:09:54 2017 -0700
>> # Node ID 58c9ffb81e676df4613c86c9ebd75836f1567ced
>> # Parent  0d57661098e3f93e7d1ab4e206d87d39c6ce4f84
>> # Available At https://bitbucket.org/quark-zju/hg-draft
>> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 58c9ffb81e67
>> test-check-pylint: match its output
>>
>> "pylint --version" shows:
>>
>>   pylint 2.0.0,
>>   astroid 1.5.0
>>   Python 2.7.13 (default, Dec 21 2016, 07:16:46)
>>   [GCC 6.2.1 20160830]
>>
>> I got "Your code has been rated at 10.00/10" every time and didn't know how
>> to turn it off. Therefore the fix.
>
> Queued, thanks.

We could probably add something to the "fakerc" config file to make sure 
this is disabled instead.

Cheers,

Patch

diff --git a/tests/test-check-pylint.t b/tests/test-check-pylint.t
--- a/tests/test-check-pylint.t
+++ b/tests/test-check-pylint.t
@@ -14,2 +14,6 @@  Current checks:
   >   --enable=W0102 --reports=no \
   >   mercurial hgext hgext3rd
+   (?)
+  ------------------------------------ (?)
+  Your code has been rated at 10.00/10 (?)
+   (?)