Patchwork check-code: fix "covert" typo

login
register
mail settings
Submitter via Mercurial-devel
Date April 3, 2017, 6:34 p.m.
Message ID <f2e00c31f5c45b985615.1491244451@martinvonz.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/19937/
State Accepted
Headers show

Comments

via Mercurial-devel - April 3, 2017, 6:34 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1491244251 25200
#      Mon Apr 03 11:30:51 2017 -0700
# Node ID f2e00c31f5c45b98561577ce6e9acb869d4e331a
# Parent  ac69675fff1caacf143ab7f0bda668e6e325670a
check-code: fix "covert" typo
Augie Fackler - April 3, 2017, 7:09 p.m.
On Mon, Apr 03, 2017 at 11:34:11AM -0700, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz@google.com>
> # Date 1491244251 25200
> #      Mon Apr 03 11:30:51 2017 -0700
> # Node ID f2e00c31f5c45b98561577ce6e9acb869d4e331a
> # Parent  ac69675fff1caacf143ab7f0bda668e6e325670a
> check-code: fix "covert" typo

queued thanks

>
> diff -r ac69675fff1c -r f2e00c31f5c4 contrib/check-code.py
> --- a/contrib/check-code.py	Wed Mar 29 21:43:38 2017 +0900
> +++ b/contrib/check-code.py	Mon Apr 03 11:30:51 2017 -0700
> @@ -338,7 +338,7 @@
>      (r'^import BaseHTTPServer', "use util.httpserver instead"),
>      (r'\.next\(\)', "don't use .next(), use next(...)"),
>      (r'([a-z]*).revision\(\1\.node\(',
> -     "don't covert rev to node before passing to revision(nodeorrev)"),
> +     "don't convert rev to node before passing to revision(nodeorrev)"),
>
>      # rules depending on implementation of repquote()
>      (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
> diff -r ac69675fff1c -r f2e00c31f5c4 tests/test-check-code.t
> --- a/tests/test-check-code.t	Wed Mar 29 21:43:38 2017 +0900
> +++ b/tests/test-check-code.t	Mon Apr 03 11:30:51 2017 -0700
> @@ -11,7 +11,7 @@
>    > sed 's-\\-/-g' | xargs "$check_code" --warnings --per-file=0 || false
>    contrib/perf.py:859:
>     >             r.revision(r.node(x))
> -   don't covert rev to node before passing to revision(nodeorrev)
> +   don't convert rev to node before passing to revision(nodeorrev)
>    Skipping i18n/polib.py it has no-che?k-code (glob)
>    mercurial/demandimport.py:312:
>     >     if os.environ.get('HGDEMANDIMPORT') != 'disable':
> diff -r ac69675fff1c -r f2e00c31f5c4 tests/test-contrib-perf.t
> --- a/tests/test-contrib-perf.t	Wed Mar 29 21:43:38 2017 +0900
> +++ b/tests/test-contrib-perf.t	Mon Apr 03 11:30:51 2017 -0700
> @@ -167,5 +167,5 @@
>    > "$TESTDIR"/check-perf-code.py contrib/perf.py
>    contrib/perf.py:859:
>     >             r.revision(r.node(x))
> -   don't covert rev to node before passing to revision(nodeorrev)
> +   don't convert rev to node before passing to revision(nodeorrev)
>    [1]
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff -r ac69675fff1c -r f2e00c31f5c4 contrib/check-code.py
--- a/contrib/check-code.py	Wed Mar 29 21:43:38 2017 +0900
+++ b/contrib/check-code.py	Mon Apr 03 11:30:51 2017 -0700
@@ -338,7 +338,7 @@ 
     (r'^import BaseHTTPServer', "use util.httpserver instead"),
     (r'\.next\(\)', "don't use .next(), use next(...)"),
     (r'([a-z]*).revision\(\1\.node\(',
-     "don't covert rev to node before passing to revision(nodeorrev)"),
+     "don't convert rev to node before passing to revision(nodeorrev)"),
 
     # rules depending on implementation of repquote()
     (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
diff -r ac69675fff1c -r f2e00c31f5c4 tests/test-check-code.t
--- a/tests/test-check-code.t	Wed Mar 29 21:43:38 2017 +0900
+++ b/tests/test-check-code.t	Mon Apr 03 11:30:51 2017 -0700
@@ -11,7 +11,7 @@ 
   > sed 's-\\-/-g' | xargs "$check_code" --warnings --per-file=0 || false
   contrib/perf.py:859:
    >             r.revision(r.node(x))
-   don't covert rev to node before passing to revision(nodeorrev)
+   don't convert rev to node before passing to revision(nodeorrev)
   Skipping i18n/polib.py it has no-che?k-code (glob)
   mercurial/demandimport.py:312:
    >     if os.environ.get('HGDEMANDIMPORT') != 'disable':
diff -r ac69675fff1c -r f2e00c31f5c4 tests/test-contrib-perf.t
--- a/tests/test-contrib-perf.t	Wed Mar 29 21:43:38 2017 +0900
+++ b/tests/test-contrib-perf.t	Mon Apr 03 11:30:51 2017 -0700
@@ -167,5 +167,5 @@ 
   > "$TESTDIR"/check-perf-code.py contrib/perf.py
   contrib/perf.py:859:
    >             r.revision(r.node(x))
-   don't covert rev to node before passing to revision(nodeorrev)
+   don't convert rev to node before passing to revision(nodeorrev)
   [1]