From patchwork Sun Apr 2 23:12:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [6,of,8] test-serve: disable unfixable tests on Windows From: Matt Harbison X-Patchwork-Id: 19916 Message-Id: To: mercurial-devel@mercurial-scm.org Date: Sun, 02 Apr 2017 19:12:52 -0400 # HG changeset patch # User Matt Harbison # Date 1491112267 14400 # Sun Apr 02 01:51:07 2017 -0400 # Node ID f2df1dcd45d44a7cb79663fdc22054797703385a # Parent 3196a52c528f537c04a9fdc61d6ee0f75ffb3223 test-serve: disable unfixable tests on Windows These tests would run if hghave.has_serve() were enabled on Windows. Windows has no issue allowing an unpriviledged process to open port 13, so it doesn't abort. The other tests are related to how MSYS tries to be helpful and converts Unix constructs to the Windows equivalent. There isn't any way to disable this behavior, though it supposedly doesn't happen if the exe is linked against the MSYS library. diff --git a/tests/test-hgweb-commands.t b/tests/test-hgweb-commands.t --- a/tests/test-hgweb-commands.t +++ b/tests/test-hgweb-commands.t @@ -2216,6 +2216,11 @@ $ cat errors.log +MSYS changes environment variables starting with '/' into 'C:/MinGW/msys/1.0', +which changes the status line to '400 no such method: C:'. + +#if no-msys + bookmarks view doesn't choke on bookmarks on secret changesets (issue3774) $ hg phase -fs 4 @@ -2381,7 +2386,7 @@ node: (0, 6) (color 1) - +#endif $ cd .. diff --git a/tests/test-pull.t b/tests/test-pull.t --- a/tests/test-pull.t +++ b/tests/test-pull.t @@ -88,7 +88,11 @@ abort: file:// URLs can only refer to localhost [255] +MSYS changes 'file:' into 'file;' + +#if no-msys $ hg pull -q file:../test # no-msys +#endif It's tricky to make file:// URLs working on every platform with regular shell commands. diff --git a/tests/test-serve.t b/tests/test-serve.t --- a/tests/test-serve.t +++ b/tests/test-serve.t @@ -45,7 +45,7 @@ With -v and -p daytime (should fail because low port) -#if no-root +#if no-root no-windows $ KILLQUIETLY=Y $ hgserve -p daytime abort: cannot start server at 'localhost:13': Permission denied