Patchwork [2,of,4] templatefilters: unroll handling of None/False/True

login
register
mail settings
Submitter Yuya Nishihara
Date April 2, 2017, 3:28 a.m.
Message ID <54017aea6a3b5c7a668f.1491103702@mimosa>
Download mbox | patch
Permalink /patch/19902/
State Accepted
Headers show

Comments

Yuya Nishihara - April 2, 2017, 3:28 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1491101485 -32400
#      Sun Apr 02 11:51:25 2017 +0900
# Node ID 54017aea6a3b5c7a668f44df4399102b94a9eecd
# Parent  80483134bdbaeb72809a3e9683a263c7e166b3c8
templatefilters: unroll handling of None/False/True

It doesn't make sense to use a dict here.

Patch

diff --git a/mercurial/templatefilters.py b/mercurial/templatefilters.py
--- a/mercurial/templatefilters.py
+++ b/mercurial/templatefilters.py
@@ -219,8 +219,12 @@  def indent(text, prefix):
 
 @templatefilter('json')
 def json(obj):
-    if obj is None or obj is False or obj is True:
-        return {None: 'null', False: 'false', True: 'true'}[obj]
+    if obj is None:
+        return 'null'
+    elif obj is False:
+        return 'false'
+    elif obj is True:
+        return 'true'
     elif isinstance(obj, (int, long, float)):
         return str(obj)
     elif isinstance(obj, str):