From patchwork Sat Apr 1 07:29:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [3,of,6] tests: store ETag when using --headeronly From: Gregory Szorc X-Patchwork-Id: 19889 Message-Id: <4cec8e88d09775ee6478.1491031747@ubuntu-vm-main> To: mercurial-devel@mercurial-scm.org Date: Sat, 01 Apr 2017 00:29:07 -0700 # HG changeset patch # User Gregory Szorc # Date 1491031312 25200 # Sat Apr 01 00:21:52 2017 -0700 # Node ID 4cec8e88d09775ee6478e307e9dde94af5b9fcfd # Parent d20811d936ba24bcfab04ed28d06365b52784ae6 tests: store ETag when using --headeronly Previously, --headeronly would prevent --twice from working because the ETag wasn't stored when --headeronly was used. This feels like a bug. That feeling is reaffirmed by the fact that this change doesn't regress any tests. diff --git a/tests/get-with-headers.py b/tests/get-with-headers.py --- a/tests/get-with-headers.py +++ b/tests/get-with-headers.py @@ -78,8 +78,8 @@ def request(host, path, show): else: sys.stdout.write(data) - if twice and response.getheader('ETag', None): - tag = response.getheader('ETag') + if twice and response.getheader('ETag', None): + tag = response.getheader('ETag') return response.status