Patchwork [remotefilelog-ext] debian: clean with "--component remotefilelog" to not need Cython

login
register
mail settings
Submitter via Mercurial-devel
Date March 31, 2017, 4:50 p.m.
Message ID <c7cfe5ae5271e68ae78f.1490979046@martinvonz.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/19872/
State Accepted
Headers show

Comments

via Mercurial-devel - March 31, 2017, 4:50 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1490978878 25200
#      Fri Mar 31 09:47:58 2017 -0700
# Node ID c7cfe5ae5271e68ae78f53516b68fe60e896a7d2
# Parent  b5df1d5f3e303a75c550f8e8770afad9945edd86
debian: clean with "--component remotefilelog" to not need Cython

I was trying to build a Debian package on a build machine without
Cython installed. That failed when it was running "dh clean --with
python2", which calls the dh_auto_clean target, which in turn calls
"python setup.py clean --all". Overriding that target to pass
"--component remotefilelog" seems to solve the problem.

The internet wasn't able to tell me what else is supposed to be done
in dh_auto_clean, so I can only hope that nothing else than "python
setup.py clean --all" was supposed to be done there.
Durham Goode - April 3, 2017, 11:25 p.m.
On 3/31/17 9:50 AM, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz@google.com>
> # Date 1490978878 25200
> #      Fri Mar 31 09:47:58 2017 -0700
> # Node ID c7cfe5ae5271e68ae78f53516b68fe60e896a7d2
> # Parent  b5df1d5f3e303a75c550f8e8770afad9945edd86
> debian: clean with "--component remotefilelog" to not need Cython
>
> I was trying to build a Debian package on a build machine without
> Cython installed. That failed when it was running "dh clean --with
> python2", which calls the dh_auto_clean target, which in turn calls
> "python setup.py clean --all". Overriding that target to pass
> "--component remotefilelog" seems to solve the problem.
>
> The internet wasn't able to tell me what else is supposed to be done
> in dh_auto_clean, so I can only hope that nothing else than "python
> setup.py clean --all" was supposed to be done there.

Pushed, thanks!

Patch

diff -r b5df1d5f3e30 -r c7cfe5ae5271 contrib/debian/rules
--- a/contrib/debian/rules	Thu Mar 30 04:17:12 2017 -0700
+++ b/contrib/debian/rules	Fri Mar 31 09:47:58 2017 -0700
@@ -6,6 +6,9 @@ 
 %:
 	dh $@ --with python2
 
+override_dh_clean:
+	python$(PYVERS) setup.py clean --all --component remotefilelog
+
 override_dh_auto_install:
 	python$(PYVERS) setup.py install --root $(CURDIR)/debian/remotefilelog --install-layout=deb --component remotefilelog
 	find $(CURDIR)/debian/remotefilelog -name '*.egg-info' -delete