Patchwork runtests: unset editor and pager related environment variables

login
register
mail settings
Submitter Jun Wu
Date March 27, 2017, 3:59 a.m.
Message ID <65f76087bc84162bdf07.1490587192@localhost.localdomain>
Download mbox | patch
Permalink /patch/19732/
State Accepted
Headers show

Comments

Jun Wu - March 27, 2017, 3:59 a.m.
# HG changeset patch
# User Jun Wu <quark@fb.com>
# Date 1490587134 25200
#      Sun Mar 26 20:58:54 2017 -0700
# Node ID 65f76087bc84162bdf0735f156d403e873e5c4e8
# Parent  e86eb75e74ce1b0803c26d86a229b9b711f6d76a
# Available At https://bitbucket.org/quark-zju/hg-draft
#              hg pull https://bitbucket.org/quark-zju/hg-draft -r 65f76087bc84
runtests: unset editor and pager related environment variables

Those environment variables could affect some configuration and future
tests. Drop them to avoid issues.
Yuya Nishihara - March 27, 2017, 1:04 p.m.
On Sun, 26 Mar 2017 20:59:52 -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark@fb.com>
> # Date 1490587134 25200
> #      Sun Mar 26 20:58:54 2017 -0700
> # Node ID 65f76087bc84162bdf0735f156d403e873e5c4e8
> # Parent  e86eb75e74ce1b0803c26d86a229b9b711f6d76a
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 65f76087bc84
> runtests: unset editor and pager related environment variables

Sure. Queued, thanks.
Augie Fackler - March 27, 2017, 1:11 p.m.
On Sun, Mar 26, 2017 at 08:59:52PM -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark@fb.com>
> # Date 1490587134 25200
> #      Sun Mar 26 20:58:54 2017 -0700
> # Node ID 65f76087bc84162bdf0735f156d403e873e5c4e8
> # Parent  e86eb75e74ce1b0803c26d86a229b9b711f6d76a
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 65f76087bc84
> runtests: unset editor and pager related environment variables

Sure, queued. Thanks.

>
> Those environment variables could affect some configuration and future
> tests. Drop them to avoid issues.
>
> diff --git a/tests/run-tests.py b/tests/run-tests.py
> --- a/tests/run-tests.py
> +++ b/tests/run-tests.py
> @@ -907,5 +907,5 @@ class Test(unittest.TestCase):
>
>          for k in ('HG HGPROF CDPATH GREP_OPTIONS http_proxy no_proxy ' +
> -                  'HGPLAIN HGPLAINEXCEPT ' +
> +                  'HGPLAIN HGPLAINEXCEPT EDITOR VISUAL PAGER ' +
>                    'NO_PROXY CHGDEBUG').split():
>              if k in env:
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -907,5 +907,5 @@  class Test(unittest.TestCase):
 
         for k in ('HG HGPROF CDPATH GREP_OPTIONS http_proxy no_proxy ' +
-                  'HGPLAIN HGPLAINEXCEPT ' +
+                  'HGPLAIN HGPLAINEXCEPT EDITOR VISUAL PAGER ' +
                   'NO_PROXY CHGDEBUG').split():
             if k in env: