Submitter | Jun Wu |
---|---|
Date | March 27, 2017, 12:14 a.m. |
Message ID | <14659f3ffd6070d6e153.1490573691@localhost.localdomain> |
Download | mbox | patch |
Permalink | /patch/19715/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 29F0C2C25E; Sun, 26 Mar 2017 20:15:25 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vlt4wj_2kOuW; Sun, 26 Mar 2017 20:15:24 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id 85B522C254; Sun, 26 Mar 2017 20:15:21 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id E1BC12C24E for <mercurial-devel@mercurial-scm.org>; Sun, 26 Mar 2017 20:15:19 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ko7iJwFUf5tq for <mercurial-devel@mercurial-scm.org>; Sun, 26 Mar 2017 20:15:19 -0400 (EDT) Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by mercurial-scm.org (Postfix) with ESMTPS id 16C372C251 for <mercurial-devel@mercurial-scm.org>; Sun, 26 Mar 2017 20:15:18 -0400 (EDT) Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2R09u3t017642 for <mercurial-devel@mercurial-scm.org>; Sun, 26 Mar 2017 17:15:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=content-type : mime-version : content-transfer-encoding : subject : message-id : in-reply-to : references : date : from : to; s=facebook; bh=VV1kKwsuWn95G1oddtcmJUiBuZWzkXMiYiX0UVfmE7Y=; b=LnvH6anOaRswmkGOT8yQN66zMUuYEaVkCYcQJXXkTJ1B5lPiWBddixvw0f0+XvNWOtUw 8m1gVh8Lir5CsARxS6DSOdYiTmKFGHt8hOMCufoZmHdOaN57ANG1ra/6pZdxyF1s4wYz B8qCCsyz9Fawf5IdYP+OgZfMPKbIBMna+WQ= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 29dkv9c19u-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for <mercurial-devel@mercurial-scm.org>; Sun, 26 Mar 2017 17:15:18 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.14) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 26 Mar 2017 17:15:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VV1kKwsuWn95G1oddtcmJUiBuZWzkXMiYiX0UVfmE7Y=; b=e6Mzwx3kVWmPaGZUOqUJNCyGmViGDJZbtkMEVCx0Fv15ShjUdZNT9xqR6jMYLhu6ZFuQrDds58KzV4XY1+JNhoae5iliKzzTdi8iDoXHlY+MGDwTfU9lIiOpjPIYducOj6MOZm2/A9O39DC1bNEo+DMdI6VoC8+BbjmLD280nlw= Authentication-Results: mercurial-scm.org; dkim=none (message not signed) header.d=none; mercurial-scm.org; dmarc=none action=none header.from=fb.com; Received: from localhost.localdomain (69.181.140.208) by BN6PR15MB1506.namprd15.prod.outlook.com (10.172.151.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Mon, 27 Mar 2017 00:15:15 +0000 MIME-Version: 1.0 Subject: [PATCH 2 of 5] merge: use ProgrammingError X-Mercurial-Node: 14659f3ffd6070d6e153f633e18fef9e8df29485 X-Mercurial-Series-Index: 2 X-Mercurial-Series-Total: 5 Message-ID: <14659f3ffd6070d6e153.1490573691@localhost.localdomain> X-Mercurial-Series-Id: <92d7eff3f4c7e44e8aab.1490573690@localhost.localdomain> In-Reply-To: <92d7eff3f4c7e44e8aab.1490573690@localhost.localdomain> References: <92d7eff3f4c7e44e8aab.1490573690@localhost.localdomain> User-Agent: Mercurial-patchbomb/4.1.1+542-b2fb0fd239b8 Date: Sun, 26 Mar 2017 17:14:51 -0700 From: Jun Wu <quark@fb.com> To: <mercurial-devel@mercurial-scm.org> X-Originating-IP: [69.181.140.208] X-ClientProxiedBy: DB6PR04CA0016.eurprd04.prod.outlook.com (10.170.208.29) To BN6PR15MB1506.namprd15.prod.outlook.com (10.172.151.146) X-MS-Office365-Filtering-Correlation-Id: 601446cd-4f3f-4987-70e8-08d474a65859 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN6PR15MB1506; X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1506; 3:5Vcb6SiDLIfyPQhXfW03mBSYwh19st7vJiMF8mr0tw66caLsamyW2qFp5JrBghgMD6kw4BtUQgNiRe9bAI7x5VvGOyrnWW87q5WCtZ4i/EH8yqEa3rYo05bN3788SMzN6uJHnmz0a/nnVhiZRmsEMARYqi/JMCWbZAW56ikRb6iuv0sdBhuAyeIiyFDpITSwgFDr4CCTH4qngRtjydNOsQsFjn6uAoExckCd9B352JKQsBY1DCDr5NeYxO4WT3A+F83TnetgwEs0Pc/AAcVtkA==; 25:+ZYt/rPWyXVy64oAl/z0S56cXMxMGuBN2ixhJgfjF8f+5o172eIiHcZfrAHfvPrgFpvFqlxkE4poIOs18vSBnxF+TekG/S38iEoLPm7n/BejcHI4xbrORVD+JhVbzp5pTKL4oK7LksDg8yc0LfWAbQwbZhiX4xRdyE47ftBUzQtmXV8HGq6ZCLeBjsS/rFa7pv9hXJyMKrzmw8jLt84txS/kSLl/y0E/3Yo/kjvp2onquDUkrOQARrLOOZNR+U//YDCdZwo6lE+/KueHXRDrdNG7geuCc+fb6NO217KVFsuH0rrxueBuNaa1HlJeyhEWx0ee+91JXdZneZdiqLWPXzi4NmruXpq80/PjqFCqzx8tm1g1nkTUk/dV5K6v2C4MafOmqTMwzpz8DjZFrbgJEQPi/6+Xde+7uaXLYB/R0J61OQS6f2ahzUaajGmNZ2GJELF6cLDk1ormV+lhIsnojQ== X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1506; 31:bKlK46lcKBOjonyaPC4EyU/hzBJOi1vr/hoXm9fZgnhbrulwRIsgeDKEGIvXL64YPLZZHf8svQB0+bUsytoosLJir/BBOEXj3/5iS5oLScCp1ovMjrUCFwyC71/yQOBvErHFnpuPHDlvEnC+giNOK5yAYkjkOKLIfkbyXFg9x0AMqtIHeXvcz1pgy0PBgADw5cKnVFvDkx3NO4uIPGI2KBmrvw8He6CgPZpoeTfWWHV/adDQQ5V4+KDGl8RoW9Fi5C+LmanW5YFMpEAj0kTPbsKxbjyF2ZDHz2TaopxY0p0=; 20:6isH3B87QA4YI5DxkMyG5pFC/6uQWbrveZTEJC7SIAyPmOFmuE2LWlmHVXVnZsoY8Eerlc85KqZrZOfTn81oaj2kuwlB9QfiVZx7X4BkGWPDhsezLZfGWmbFIjjnM5O3O8FFA5WcPioWxoxCHCMlCF/TIEUi7kwzMHj1YBJknQ3nWcF34+fE8p/M9k0AmGjDijRfLAmlGTLHZGAb/NIhLUp+qFdyZF6GyiDAurOO3/SLYBwn5+D+jWt7dWx9FoZflR16Jbd0JeTAjy9D5iwYfEjWUN4h8ZxzCRX7p6qVH+aeJb69Ku++fArtiHRMvn+CdRV2vnwkK5kGyoSRlw5+sq5kzlpZVjrH3m0x6Hp7TcIaxPx3HOIOvrVEHw4uUDmRSVosEBG95dvMj5q1AMOFMA/+SU0gzISSd0MZOtU8WmMzYHPwaOePW7QmMYmqnQ3edte3HbVv2F2jZbbFm73wW99QkdJYZwXZUe9PY8Kq9bpkQgp2K6gMkkK9mhlHlK2V X-Microsoft-Antispam-PRVS: <BN6PR15MB150679A38339BDFF16FE7E80CD330@BN6PR15MB1506.namprd15.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(63843785518722); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558025)(6072148); SRVR:BN6PR15MB1506; BCL:0; PCL:0; RULEID:; SRVR:BN6PR15MB1506; X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1506; 4:iDxjVY/sZyHfBh8r9dPKB+CzGiprW0S2bYBZQdKgN5OGgCamMc6uiOLfLfIWmdQUUfF6aGweqs26yT6L6psR4KCgYMTICLR7LfPR+OzSsF5wzDYMaU4Aq5Wk6g3ZDfFZKu/zqBGt4N5pXfpjk1Jkoj7VtIJGdFdz4NfseLD0fcb5xgQnAqtZ8ociePi2BnuVzQ/QxzcUNOEDV4oLHlXTEII7/MmhBBN5lcAs6StBokuIraaLtYjJaPC/2klyh/God+MbJaCfo+BZpyD9odGo+2v5aHV9S10wkGajntUjiQsLJnUndnKr6V6jKJ0TZ9hLsPATVS+oQccFwESKSXesfqJ6ipXMT0okC6EjtDhIOqD6uc0zQ/8suRgw6GO3DfxFYdFpyQi6CeBrY6QeHxBLCG2fCaI5p/P6aw8lQfVNkZQhL4cpC3tw7z6IE68NJ/hOJtmujAPV/4r3BzwmKqQHEG7ddypvyMmnQP4l7uquz2DpEjpYJ1AtvkMNRw+vvGu7TAvVYCSGnKesjduekYMh8qHyLHs3WpMsnuV5eT0qneG8r5Y2H8OIWnXi+6bQPk5fdB76onOaRdYMQnDLtlqXN5Dnn9xM6ynXN/IBidReOP9RG3YKN0JilZGgP6pYAwsKIL8M3jXb4jACisL19ntvAoZULhJKAJtL/7/1dYBAY15FwNaakWNIQSvBkdmEK7MS X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6069001)(39840400002)(39410400002)(39450400003)(50466002)(38730400002)(110136004)(42186005)(25786009)(54356999)(46406003)(50986999)(76176999)(7736002)(230700001)(305945005)(53936002)(6306002)(66066001)(47776003)(9686003)(83506001)(55016002)(6666003)(23726003)(3846002)(86362001)(97756001)(5660300001)(6506006)(2950100002)(6916009)(2906002)(8676002)(81166006)(4001350100001)(33646002)(6116002)(189998001)(2351001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR15MB1506; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR15MB1506; 23:XS9PAg7Wqxmte8Bh1drHkr9LH6u9wKogEgPJSUebM?= =?us-ascii?Q?gn/NKlL6yKU8LffmTrpjrhcIDIR+kiZR4rs7l8iQqxD8xgAuIO4yXKeOP910?= =?us-ascii?Q?HnEQ8+PKmZhDpwtEbN0zwdq7A3b2hYdsoY5iqgOTphi1myRFL2sc0aARqYaR?= =?us-ascii?Q?5nhakwso+u6tzRJ/Gv64aN9c/EPSPdrQAdVMG9DTQ3uS3tXirin41Lp21FBr?= =?us-ascii?Q?HR3ovi4rRubW3tgPe/ucjIZjr11LsDbmTE4nLMs/k6H1BC5BCce03FT9NlIX?= =?us-ascii?Q?kLWk7AnGmtWg1j+HOQ5bIOmzrZzJWsuNqML1rVmLqfcLqKwtDCHKForKDeJ6?= =?us-ascii?Q?lSoTaG+O56ubXVStsp/RWE1ruR4amcXkQvncLtO8hMHL8RtstZnEhpcbvFxP?= =?us-ascii?Q?QpwTmJ5KrcZ6euvrvqMb59ZYTcTkKJtu00NjBy3HTYIamksdyaaxAJM4uOIl?= =?us-ascii?Q?hDH7oSjosNzLd3wBSI87dV+mI2QvTGGovoiPgM3UiX+b68nczM1Mimrrqns8?= =?us-ascii?Q?NJ0KTzuvSA7I8A4rkqNOeSHGdXxvLe6tminAnvC9FmAMz57ZKk/9kySFPobo?= =?us-ascii?Q?bXaxA7pp+NWz0j8P+Tg8JTI1VLzprgsIhBBSvPXoUxTEruE15vsegkWj7JzD?= =?us-ascii?Q?I/gFH9E3KivsbTgcYLJIzgo8UQMQ+7Hm7fFxT7S6LwykysTm6O7FGwCoFcDO?= =?us-ascii?Q?bJB6DGiN6UIJW8Bqe8/7zTDJ8xOPsmx2obb9YrrBvUMwEXxquSFtuKrg6uMl?= =?us-ascii?Q?kzb1spuXBG5ycxX5rQ6V6/xWhqEgA9uLo13BUeh+TeB+xAO3MrJJD7uZjUds?= =?us-ascii?Q?qTpsfQhTDl9jd1Y9mzF+JNmTWjBNzxmb56ZHUPSqMQklB8mT8IM6JRDTSwOq?= =?us-ascii?Q?VKHhs3+ATRKXFkLymvI4vfEkuh1IsNi0M1dRPn4uGel7QZro2aAqp1iVD0Ok?= =?us-ascii?Q?CSgn7J7V+GyqewOh779GbVR4aFPxnwln9hbGn1/JK1tta2Cun/T85Y6Gr1lr?= =?us-ascii?Q?jOrgnsnxW3bm2ZNUnafCF/ZFHzvv+KDCIImzJEjomUb5/B9D4ui2IM1vuqgA?= =?us-ascii?Q?1rJbww=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1506; 6:w+ny1k2XbD+bRr1qAM0Iv0wB6kN52Bc14YIVXi/nBLU4cL8K7NSNXZ/HihTkiL4xdXXlYzxWuGg02eHp1zG8QZRiLJLBx3NUKQelOQsaaED3eRe3sUgh28dOdZon5fRrJ2o6sLZHZ8e9zyqd/mYXWA6BRwppeB0zEcnnFZ18tsESdhLNrgLfwX0fZY489pxm50KZR1fTqYCIy3qxzqyoYx+gioMzjBcJ15qSgmarv7dBXRNtpsUJwkBYrLc628dwNMoQgtGhHM4XhInQCE4pFGE0BxOo+6/fKoBAPHuHLnvJ5+gFwRLtg7FF18HAIqb9GVdRah0mUfzUqM0HNI4zInPpudw9s5+qPlu6tQU5ThqX83DoExnuRgP/c8+RPCBIb7IZqvtpDyYADXFMDYyc5g==; 5:BjtUo8NJoGzCwh6nq93J3OgI7BUmk7NEi/sgOMZHztlbJLhmFFpvsXKh3S9OOL06GDr99y/OvH75S1YUPoXWw0FXfsssJ1ufGyhXJgjiMzEDdaYABMWcMIBnp3WPN6vS3gpGNtaM1QDo/zxppZ/6j7vqqIMG3BzsgsNHfolFn5Q=; 24:DBp5L8KqNv5dFHrgNCJYC6zuglzaEMt8bXVglwk6jb51BhxPbc5xwDjb0iXdn7b9z+tTHV47lp3QO6/C5TvyWVn8FDHomUBslv7YggSiab8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR15MB1506; 7:+pJCvdipVhSjuL/HugkI/9hVMV2OcC37b4UW8KqCea/7VoJ/gCr/X7L6tYXQTcskyKs7WgJOzCTXDSS9yvNIDq0Drz9GRMMERPsTo4A40W5tVdykDRUEmIuoF9EFgd2ufGLxtGCNbvu/Y1/4TQy8KFi7JLrG6L15WFXuWV/R3WGhgM0e6isoWEf5G2VaC6dKRtGecJCKApvXB+o14XnK1xYxTfs3ucFC2TkVUFPhOGPg+G/Ex204+7OHOA+HF/VAe4Q1epe2ymmKzIQytuNoUptQFWuwUT0QQwdJDwgcvkSCY/Bsjxam8xlaYuNjMB8pQl78jrMcQEbFbiB/2W33HQ==; 20:1nhHPv0VEyBZrQEpOF6Fi2YgByLOkFZ447GvYZaUtJaHSWai3AH5A+nFRL4m47gdZ8xpiuJND3XcwySxqBYKG+dBUSe1AAmhqZNgQ9lDNNv1cCHSWOntOlZrikIUkOWpsa3BiaF3LL+X2gFB+AfBBUU7WksNxYgyL64r/pwfF70= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 00:15:15.2364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1506 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-26_19:, , signatures=0 X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Jun Wu - March 27, 2017, 12:14 a.m.
Patch
diff --git a/mercurial/merge.py b/mercurial/merge.py --- a/mercurial/merge.py +++ b/mercurial/merge.py @@ -316,5 +316,6 @@ class mergestate(object): def localctx(self): if self._local is None: - raise RuntimeError("localctx accessed but self._local isn't set") + msg = "localctx accessed but self._local isn't set" + raise error.ProgrammingError(msg) return self._repo[self._local] @@ -322,5 +323,6 @@ class mergestate(object): def otherctx(self): if self._other is None: - raise RuntimeError("otherctx accessed but self._other isn't set") + msg = "otherctx accessed but self._other isn't set" + raise error.ProgrammingError(msg) return self._repo[self._other]