Patchwork [1,of,3,stable,V3] ancestor.deepest: sort revs in C version

login
register
mail settings
Submitter Siddharth Agarwal
Date July 25, 2013, 11:08 p.m.
Message ID <acd8063547ca3cb47f65.1374793693@dev1091.prn1.facebook.com>
Download mbox | patch
Permalink /patch/1968/
State Superseded
Headers show

Comments

Siddharth Agarwal - July 25, 2013, 11:08 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1374787237 25200
#      Thu Jul 25 14:20:37 2013 -0700
# Branch stable
# Node ID acd8063547ca3cb47f65140be7930b60fefd9cdc
# Parent  7a5cdf0c90ed57f914d864fdb7d0cbfcaa2637fa
ancestor.deepest: sort revs in C version

This isn't strictly necessary, but it makes the code more consistent with the
Python version.

Patch

diff --git a/mercurial/parsers.c b/mercurial/parsers.c
--- a/mercurial/parsers.c
+++ b/mercurial/parsers.c
@@ -1311,6 +1311,9 @@ 
 		goto bail;
 	}
 
+	if (PyList_Sort(revs) == -1)
+		goto bail;
+
 	for (i = 0; i < revcount; i++) {
 		int n = (int)PyInt_AsLong(PyList_GET_ITEM(revs, i));
 		long b = 1l << i;